Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:add consumer override of quotas #468

Merged
merged 7 commits into from
Mar 18, 2021
Merged

feat:add consumer override of quotas #468

merged 7 commits into from
Mar 18, 2021

Conversation

ericyz
Copy link
Contributor

@ericyz ericyz commented Oct 5, 2020

There are quite a few use cases to add customer quota override during the project creation process. The changes is to add the capability into the CFT module

@ericyz ericyz changed the title feat:add consumer override of quotas feat:add consumer quota override of quotas Oct 5, 2020
@ericyz ericyz changed the title feat:add consumer quota override of quotas feat:add consumer override of quotas Oct 5, 2020
morgante
morgante suggested changes Oct 19, 2020
View reviewed changes
modules/quota_manager/README.md Show resolved Hide resolved
main.tf Show resolved Hide resolved
@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jan 20, 2021
@github-actions github-actions bot closed this Jan 28, 2021
@ocervell
Copy link
Contributor

I'd love to see this land. @ericyz would you please address @morgante 's comments so that we can add this to Project Factory ?

@ericyz
Copy link
Contributor Author

ericyz commented Mar 16, 2021

Oh, I missed out this one. For sure, I am updating it now

@ericyz ericyz reopened this Mar 16, 2021
@comment-bot-dev
Copy link

comment-bot-dev commented Mar 16, 2021 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@ericyz ericyz requested a review from a team as a code owner March 16, 2021 03:04
@morgante
Copy link
Contributor

@ericyz Please address linting errors.

morgante
morgante suggested changes Mar 16, 2021
View reviewed changes
examples/shared_vpc/main.tf Outdated Show resolved Hide resolved
modules/gsuite_enabled/README.md Outdated Show resolved Hide resolved
modules/quota_manager/main.tf Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the Stale label Mar 16, 2021
@ericyz ericyz requested a review from morgante March 18, 2021 22:35
@morgante morgante merged commit 045923d into master Mar 18, 2021
This was referenced Aug 18, 2022
Closed
Closed
@release-please release-please bot mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@adrienthebo adrienthebo Awaiting requested review from adrienthebo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericyz @ocervell @comment-bot-dev @morgante