Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add impersonate_service_account to shared_vpc module to pass to core_project_factory #477

Merged
merged 1 commit into from
Oct 11, 2020
Merged

Add impersonate_service_account to shared_vpc module to pass to core_project_factory #477

merged 1 commit into from
Oct 11, 2020

Conversation

davidholsgrove
Copy link
Contributor

No description provided.

@davidholsgrove davidholsgrove requested a review from a team as a code owner October 11, 2020 22:31
@davidholsgrove davidholsgrove mentioned this pull request Oct 11, 2020
Closed
bharathkkb
bharathkkb approved these changes Oct 11, 2020
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharathkkb bharathkkb merged commit e9f0c8f into terraform-google-modules:master Oct 11, 2020
@davidholsgrove davidholsgrove deleted the feature/add-impersonate_service_account branch October 12, 2020 00:25
This was referenced Aug 18, 2022
Closed
Closed
@release-please release-please bot mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidholsgrove @bharathkkb