fix: Change budget module: Accept list of project numbers instead of …

[switj]

…project ID #544

Hello 👋 this is my first PR.

I've reviewed the contributing guidelines but if I've missed anything please direct me at the relevant doc/section so I can fix the issue.

Fixes #544

[comment-bot-dev]

Thanks for the PR! 🚀
✅ Lint checks have passed.

[morgante]

/gcbrun

[morgante]

Unfortunately this causes an error:

       Error: Invalid for_each argument
       
         on ../../../modules/budget/main.tf line 33, in data "google_project" "project":
         33:   for_each   = toset(var.projects)
       
       The "for_each" value depends on resource attributes that cannot be determined
       until apply, so Terraform cannot predict how many instances will be created.
       To work around this, use the -target argument to first apply only the
       resources that the for_each depends on.

[switj]

@morgante thanks for identifying the error and sharing so I could address the issue.

I had some issues setting up the integration tests which I've since resolved. There are still a few tests that don't seem to run properly with my org but overall I think I'm in a better place to catch these issues myself.

[morgante]

Thanks @switj, this looks good and I think the test failure is ephemeral.

[morgante]

/gcbrun

[morgante]

/gcbrun

[switj]

hiya 👋 @morgante bumping this PR.

I'm happy to rework the PR or spend additional time looking at ephemeral test failures if that makes the review easier. If there is anything I can help let me know.

[morgante]

I think the error is unrelated.