Replace "true"/"false" strings with bool values #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🚀 |
morgante
suggested changes
Mar 17, 2021
| @@ -34,7 +34,7 @@ provider "gsuite" { | |||
| module "project-factory" { | |||
There was a problem hiding this comment.
We shouldn't touch the old upgrading docs as we won't be backporting this change.
There was a problem hiding this comment.
ah in that way, sure, will roll it back :)
|
@gaspar-chilingarov Thanks for working on this! We've had the old syntax hanging around for too long. |
gaspar-chilingarov
force-pushed
the
feature/boolean-values-cleanup
branch
from
83d2df3 to
614c640
Compare
gaspar-chilingarov
force-pushed
the
feature/boolean-values-cleanup
branch
from
99e6f13 to
e6234c8
Compare
|
@morgante I have no idea why integration tests were failing before :P now it seems to be working. I've rebased, squashed, it should be nice single commit now. I'm not sure if this should wait until next major release, because it may accidentaly break somehing somewhere. |
|
@gaspar-chilingarov Looks like they're passing now, thanks! This shouldn't break anything so I'm going to merge. |
morgante
approved these changes
Mar 30, 2021
This was referenced Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the remainders of the Terraform v0.12.x syntax