Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: plumb grant_services_network_role for root module #619

Merged
merged 1 commit into from
Sep 23, 2021
Merged

fix: plumb grant_services_network_role for root module #619

merged 1 commit into from
Sep 23, 2021

Conversation

bharathkkb
Copy link
Member

Looks like we forgot to add this to the root module in #618

@bharathkkb bharathkkb requested a review from a team as a code owner September 23, 2021 18:45
morgante
morgante suggested changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bharathkkb We also need to do this in the gsuite and service_project submodule.

@comment-bot-dev
Copy link

comment-bot-dev commented Sep 23, 2021 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

morgante
morgante previously approved these changes Sep 23, 2021
View reviewed changes
@bharathkkb
Copy link
Member Author

@morgante added to gsuite. service_project was added in #618 and validated with a test.

@bharathkkb
Copy link
Member Author

Reverted gsuite module changes as discussed offline

@sandy-0007 sandy-0007 mentioned this pull request Sep 23, 2021
Merged
@morgante morgante merged commit 560396d into master Sep 23, 2021
@sandy-0007 sandy-0007 mentioned this pull request Sep 28, 2021
Merged
This was referenced Aug 18, 2022
Closed
Closed
@release-please release-please bot mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bharathkkb @comment-bot-dev @morgante