Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add network service tier setting #640

Merged

Conversation

jawnsy
Copy link
Contributor

@jawnsy jawnsy commented Nov 30, 2021

This allows users to configure the project default Network Service
Tier.

Closes: #639

This allows users to configure the project default Network Service
Tier.
@jawnsy jawnsy requested a review from a team as a code owner November 30, 2021 18:17
@comment-bot-dev
Copy link

comment-bot-dev commented Nov 30, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also propagate the variable to the shared_vpc and gsuite variants.

modules/core_project_factory/variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@jawnsy jawnsy requested a review from morgante November 30, 2021 21:49
@morgante morgante merged commit f5cce9e into terraform-google-modules:master Dec 1, 2021
@jawnsy jawnsy deleted the jawnsy/feat-add-network-tier branch December 1, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring default network service tier for projects
3 participants