Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not point to master of external CFT module during testing #685

Closed
tpdownes opened this issue Feb 18, 2022 · 1 comment
Closed

Should not point to master of external CFT module during testing #685

tpdownes opened this issue Feb 18, 2022 · 1 comment
Assignees
@apeabody
Labels
bug Something isn't working

Comments

@tpdownes
Copy link
Member

tpdownes commented Feb 18, 2022 •
edited
Loading

TL;DR

#627 allowed one of the tests to point to the HEAD master for the terraform-google-vpc-service-controls module; I believe the issue was to allow for 4.x providers. Once a released version of terraform-google-vpc-service-controls supports 4.x, we should adopt it.

Expected behavior

No response

Observed behavior

No response

Terraform Configuration

terraform-google-project-factory/test/fixtures/vpc_sc_project/main.tf

Line 22 in 44a9fec

source = "github.com/terraform-google-modules/terraform-google-vpc-service-controls//modules/regular_service_perimeter"

Terraform Version

Terraform v1.1.5
on darwin_amd64

Additional information

No response
@tpdownes tpdownes added the bug Something isn't working label Feb 18, 2022
@apeabody apeabody mentioned this issue Apr 11, 2022
Merged
@apeabody apeabody self-assigned this Apr 11, 2022
@apeabody
Copy link
Contributor

Fix in #693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apeabody apeabody

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tpdownes @apeabody