feat: added new outputs to the COS DA #783
Conversation
|
/run pipeline |
solutions/instance/outputs.tf
Outdated
| output "resource_group_name" { | ||
| description = "Resource group name" | ||
| value = module.resource_group.resource_group_name | ||
| } | ||
|
|
There was a problem hiding this comment.
The DA can be provided existing_resource_group so at best this output is intermittent.
It would appear that just returning var.resource_group_name would be more complete; but that introduces the concern of just passing an input back as an output. In which case every DA would have to do this.
Surely the calling process already has the required information. Is there more detail on why this may be desirable?
There was a problem hiding this comment.
I am creating SLZ ROKS add-on that depends on COS and KMS DA. As per the configuration it takes existing_cos_instance_name & existing_cos_resource_group for which I need resource_group_name as an output from COS DA.
I am thinking of updating the condition to this instead of directly outputting the input back
value = !var.existing_resource_group ? module.resource_group.resource_group_name : var.existing_resource_group
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
🎉 This PR is included in version 8.15.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Add in the outputs for the resource group name to be used by other DAs in a stack/addon
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers