Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/eks: Add OIDC issuer attributes to aws_eks_cluster resource and data source #10006

Merged
merged 2 commits into from
Sep 6, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 5, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9995

Release note for CHANGELOG:

* data-source/aws_eks_cluster: Add `identity` attribute (support getting OIDC issuer URL)
* resource/aws_eks_cluster: Add `identity` attribute (support getting OIDC issuer URL) 

This also updates TestAccAWSEksCluster_Version to use the two latest versions available as 1.10 and 1.11 are deprecated:

Output from acceptance testing:

--- PASS: TestAccAWSEksCluster_VpcConfig_SecurityGroupIds (1211.77s)
--- PASS: TestAccAWSEksCluster_basic (1234.32s)
--- PASS: TestAccAWSEksClusterDataSource_basic (1253.87s)
--- PASS: TestAccAWSEksCluster_Logging (1298.73s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPublicAccess (1489.44s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPrivateAccess (1875.19s)
--- PASS: TestAccAWSEksCluster_Version (2292.24s)

…nd data source

Reference: #9995

Output from acceptance testing:

```
--- PASS: TestAccAWSEksCluster_VpcConfig_SecurityGroupIds (1211.77s)
--- PASS: TestAccAWSEksCluster_basic (1234.32s)
--- PASS: TestAccAWSEksClusterDataSource_basic (1253.87s)
--- PASS: TestAccAWSEksCluster_Logging (1298.73s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPublicAccess (1489.44s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPrivateAccess (1875.19s)
--- PASS: TestAccAWSEksCluster_Version (2292.24s)
```
…wo latest versions

Replacing 1.10 and 1.11, which are both deprecated:

- aws/containers-roadmap#300
- aws/containers-roadmap#464

Output from acceptance testing:

```
--- PASS: TestAccAWSEksCluster_Version (2292.24s)
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service. labels Sep 5, 2019
@bflad bflad requested a review from a team September 5, 2019 12:00
@ghost ghost added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Sep 5, 2019
@nywilken nywilken added this to the v2.28.0 milestone Sep 6, 2019
@nywilken
Copy link
Contributor

nywilken commented Sep 6, 2019

LGTM 👍 👍

@bflad bflad merged commit 3238986 into master Sep 6, 2019
@bflad bflad deleted the f-eks-identity-oidc branch September 6, 2019 16:32
bflad added a commit that referenced this pull request Sep 6, 2019
@ghost
Copy link

ghost commented Sep 12, 2019

This has been released in version 2.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon EKS Cluster OIDC Issuer URL
2 participants