Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_opsworks_stack: Switch legacy Opsworks client User-Agent to real Terraform version #10246

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 25, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Reference: hashicorp/terraform#13024
Reference: #9570

Release note for CHANGELOG:

resource/aws_opsworks_stack: Switch legacy Opsworks client User-Agent to real Terraform version

This is required for migrating to the standalone Terraform Plugin SDK and removing our dependency on github.com/hashicorp/terraform in the future.

Output from acceptance testing:

--- PASS: TestAccAWSOpsWorksStack_classic_endpoints (28.89s)

User-Agent from testing above:

User-Agent: aws-sdk-go/1.24.4 (go1.13; darwin; amd64) APN/1.0 HashiCorp/1.0 Terraform/0.12.7

… to real Terraform version

Reference: hashicorp/terraform#13024
Reference: #9570

This migration is required for migrating to the standalone Terraform Plugin SDK and removing our dependency on github.com/hashicorp/terraform in the future.

Output from acceptance testing:

```
--- PASS: TestAccAWSOpsWorksStack_classic_endpoints (28.89s)
```

User-Agent from testing above:

```
User-Agent: aws-sdk-go/1.24.4 (go1.13; darwin; amd64) APN/1.0 HashiCorp/1.0 Terraform/0.12.7
```
@bflad bflad added service/opsworks Issues and PRs that pertain to the opsworks service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Sep 25, 2019
@bflad bflad requested review from a team September 25, 2019 19:58
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. labels Sep 25, 2019
@bflad bflad added this to the v2.30.0 milestone Sep 25, 2019
@bflad bflad merged commit 0565888 into master Sep 25, 2019
@bflad bflad deleted the td-opsworks-terraform-version branch September 25, 2019 20:11
bflad added a commit that referenced this pull request Sep 25, 2019
@ghost
Copy link

ghost commented Sep 26, 2019

This has been released in version 2.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. service/opsworks Issues and PRs that pertain to the opsworks service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants