Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_wafregional_rule_group - add tagging support + expose arn + read after create #10896

Merged
merged 11 commits into from
Nov 15, 2019

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9289

Release note for CHANGELOG:

- resource/resource_aws_wafregional_rule_group: Add `tags` argument and `arn` attribute.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSWafRegionalRuleGroup_'
=== RUN   TestAccAWSWafRegionalRuleGroup_basic
=== PAUSE TestAccAWSWafRegionalRuleGroup_basic
=== CONT  TestAccAWSWafRegionalRuleGroup_basic
--- PASS: TestAccAWSWafRegionalRuleGroup_basic (187.25s)
=== RUN   TestAccAWSWafRegionalRuleGroup_tags
=== PAUSE TestAccAWSWafRegionalRuleGroup_tags
=== CONT  TestAccAWSWafRegionalRuleGroup_tags
--- PASS: TestAccAWSWafRegionalRuleGroup_tags (349.67s)
=== RUN   TestAccAWSWafRegionalRuleGroup_changeNameForceNew
=== PAUSE TestAccAWSWafRegionalRuleGroup_changeNameForceNew
=== CONT  TestAccAWSWafRegionalRuleGroup_changeNameForceNew
--- PASS: TestAccAWSWafRegionalRuleGroup_changeNameForceNew (318.81s)
=== RUN   TestAccAWSWafRegionalRuleGroup_disappears
=== PAUSE TestAccAWSWafRegionalRuleGroup_disappears
=== CONT  TestAccAWSWafRegionalRuleGroup_disappears
--- PASS: TestAccAWSWafRegionalRuleGroup_disappears (127.25s)
=== RUN   TestAccAWSWafRegionalRuleGroup_changeActivatedRules
=== PAUSE TestAccAWSWafRegionalRuleGroup_changeActivatedRules
=== CONT  TestAccAWSWafRegionalRuleGroup_changeActivatedRules
--- PASS: TestAccAWSWafRegionalRuleGroup_changeActivatedRules (334.31s)
=== RUN   TestAccAWSWafRegionalRuleGroup_noActivatedRules
=== PAUSE TestAccAWSWafRegionalRuleGroup_noActivatedRules
=== CONT  TestAccAWSWafRegionalRuleGroup_noActivatedRules
--- PASS: TestAccAWSWafRegionalRuleGroup_noActivatedRules (110.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	562.649s

...

@DrFaust92 DrFaust92 requested a review from a team November 15, 2019 15:34
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 15, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 15, 2019
@bflad bflad added this to the v2.37.0 milestone Nov 15, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSWafRegionalRuleGroup_noActivatedRules (16.87s)
--- PASS: TestAccAWSWafRegionalRuleGroup_tags (35.24s)
--- PASS: TestAccAWSWafRegionalRuleGroup_disappears (36.43s)
--- PASS: TestAccAWSWafRegionalRuleGroup_changeNameForceNew (38.47s)
--- PASS: TestAccAWSWafRegionalRuleGroup_changeActivatedRules (45.89s)
--- PASS: TestAccAWSWafRegionalRuleGroup_basic (48.20s)

@bflad bflad merged commit 91a6c37 into hashicorp:master Nov 15, 2019
bflad added a commit that referenced this pull request Nov 15, 2019
@ghost
Copy link

ghost commented Nov 18, 2019

This has been released in version 2.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ewbankkit ewbankkit mentioned this pull request Nov 18, 2019
@DrFaust92 DrFaust92 deleted the waf-regional-rule-group-tag-support branch December 24, 2019 17:12
@ghost
Copy link

ghost commented Dec 25, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/waf Issues and PRs that pertain to the waf service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants