Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for ca_cert_identifier parameter for docdb #11041

Merged
merged 1 commit into from
Nov 28, 2019
Merged

add support for ca_cert_identifier parameter for docdb #11041

merged 1 commit into from
Nov 28, 2019

Conversation

smelchior
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

add support for ca_cert_identifier parameter for docdb

Output from acceptance testing:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSDocDBClusterInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDocDBClusterInstance_basic -timeout 120m
=== RUN   TestAccAWSDocDBClusterInstance_basic
=== PAUSE TestAccAWSDocDBClusterInstance_basic
=== CONT  TestAccAWSDocDBClusterInstance_basic
--- PASS: TestAccAWSDocDBClusterInstance_basic (1429.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1429.834s
...

@smelchior smelchior requested a review from a team November 27, 2019 20:23
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/docdb Issues and PRs that pertain to the docdb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Nov 27, 2019
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Nov 27, 2019
@gdavison gdavison self-assigned this Nov 27, 2019
@gdavison gdavison added this to the v2.41.0 milestone Nov 28, 2019
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @smelchior. We will be merging this for the next release, expected late next week, though the schedule may be affected by AWS re:Invent.

@gdavison gdavison merged commit 71f1f57 into hashicorp:master Nov 28, 2019
gdavison added a commit that referenced this pull request Nov 28, 2019
@gdavison gdavison removed their assignment Nov 28, 2019
@ghost
Copy link

ghost commented Dec 4, 2019

This has been released in version 2.41.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/docdb Issues and PRs that pertain to the docdb service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants