Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data/aws_iam_group: Add a data source for AWS IAM Group #1140

Merged
merged 1 commit into from
Jul 14, 2017
Merged

data/aws_iam_group: Add a data source for AWS IAM Group #1140

merged 1 commit into from
Jul 14, 2017

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jul 13, 2017

Fixes: #1138

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSourceIAMGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSDataSourceIAMGroup -timeout 120m
=== RUN   TestAccAWSDataSourceIAMGroup_basic
--- PASS: TestAccAWSDataSourceIAMGroup_basic (31.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	31.464s

@stack72
data/aws_iam_group: Add a data source for AWS IAM Group
9d4588a 
Fixes: #1138

```
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSourceIAMGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSDataSourceIAMGroup -timeout 120m
=== RUN   TestAccAWSDataSourceIAMGroup_basic
--- PASS: TestAccAWSDataSourceIAMGroup_basic (31.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	31.464s
```
@stack72 stack72 added the new-data-source Introduces a new data source. label Jul 13, 2017
grubernaut
grubernaut approved these changes Jul 13, 2017
View reviewed changes
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome work here

@stack72 stack72 merged commit 5815c0d into master Jul 14, 2017
@stack72 stack72 deleted the f-aws-group-datasource-1138 branch July 14, 2017 10:17
@slaunay slaunay mentioned this pull request Oct 3, 2017
Merged
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grubernaut grubernaut grubernaut approved these changes

Assignees
No one assigned
Labels
new-data-source Introduces a new data source.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add iam group data source
2 participants
@stack72 @grubernaut