Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/secretsmanager_secret - policy wait for IAM eventual consistency #14459

Merged
merged 4 commits into from
Aug 6, 2020

Conversation

DrFaust92
Copy link
Collaborator

use %w for errors
wait for policy that relies on iam role (eventual consistency)

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14449

Release note for CHANGELOG:

resouce_aws_secretsmanager_secret - policy wait for IAM eventual consistency

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsSecretsManagerSecret_policy'
--- PASS: TestAccAwsSecretsManagerSecret_policy (127.27s)

use %w for errors
wait for policy that relies on iam role (eventual consistency)
@DrFaust92 DrFaust92 requested a review from a team August 3, 2020 20:52
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 3, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small switch to constants, then good to go. 🚀

Output from acceptance testing:

--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (17.40s)
--- PASS: TestAccAwsSecretsManagerSecret_basic (18.80s)
--- PASS: TestAccAwsSecretsManagerSecret_Description (22.55s)
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (24.23s)
--- PASS: TestAccAwsSecretsManagerSecret_Tags (36.33s)
--- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (38.88s)
--- PASS: TestAccAwsSecretsManagerSecret_policy (44.96s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (45.94s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (52.32s)

aws/resource_aws_secretsmanager_secret.go Outdated Show resolved Hide resolved
aws/resource_aws_secretsmanager_secret.go Outdated Show resolved Hide resolved
@bflad bflad added the bug Addresses a defect in current functionality. label Aug 6, 2020
DrFaust92 and others added 3 commits August 6, 2020 21:45
Co-authored-by: Brian Flad <bflad417@gmail.com>
Co-authored-by: Brian Flad <bflad417@gmail.com>
@DrFaust92
Copy link
Collaborator Author

Thanks @bflad , didnt think of using that. changed according to comments.

@bflad bflad added this to the v3.1.0 milestone Aug 6, 2020
@bflad bflad merged commit 8aae084 into hashicorp:master Aug 6, 2020
bflad added a commit that referenced this pull request Aug 6, 2020
@ghost
Copy link

ghost commented Aug 7, 2020

This has been released in version 3.1.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the r/secrets_manager_iam_eventual branch August 27, 2020 18:01
@ghost
Copy link

ghost commented Sep 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secrets manager policy validation fails for principals that are just created
2 participants