Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_mq_configuration: Don't update the configuration if only tags change #14850

Merged

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14842.

Release note for CHANGELOG:

resource/aws_mq_configuration: Don't cause `latest_revision` to change if only `tags` are updated

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSMqConfiguration_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMqConfiguration_ -timeout 120m
=== RUN   TestAccAWSMqConfiguration_basic
=== PAUSE TestAccAWSMqConfiguration_basic
=== RUN   TestAccAWSMqConfiguration_withData
=== PAUSE TestAccAWSMqConfiguration_withData
=== RUN   TestAccAWSMqConfiguration_updateTags
=== PAUSE TestAccAWSMqConfiguration_updateTags
=== CONT  TestAccAWSMqConfiguration_basic
=== CONT  TestAccAWSMqConfiguration_updateTags
=== CONT  TestAccAWSMqConfiguration_withData
--- PASS: TestAccAWSMqConfiguration_withData (19.15s)
--- PASS: TestAccAWSMqConfiguration_basic (38.12s)
--- PASS: TestAccAWSMqConfiguration_updateTags (47.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	47.394s

@ewbankkit ewbankkit requested a review from a team August 26, 2020 13:57
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/mq Issues and PRs that pertain to the mq service. labels Aug 26, 2020
@bflad bflad added the bug Addresses a defect in current functionality. label Aug 28, 2020
@bflad bflad added this to the v3.5.0 milestone Aug 28, 2020
@bflad bflad self-assigned this Aug 28, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

Output from acceptance testing:

--- PASS: TestAccAWSMqConfiguration_withData (17.89s)
--- PASS: TestAccAWSMqConfiguration_basic (36.53s)
--- PASS: TestAccAWSMqConfiguration_updateTags (47.78s)

@bflad bflad merged commit be8f93c into hashicorp:master Aug 28, 2020
bflad added a commit that referenced this pull request Aug 28, 2020
@ewbankkit ewbankkit deleted the b-aws_mq_configuration-update-tags-only branch August 29, 2020 10:07
@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/mq Issues and PRs that pertain to the mq service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_mq_configuration revision increment not showing in plan
2 participants