Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Outpost by Arn in datasource #14967

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Select Outpost by Arn in datasource #14967

merged 1 commit into from
Sep 2, 2020

Conversation

johnbarney
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #13929

Release note for CHANGELOG:

* Select Outpost by Arn in datasource

Output from acceptance testing:

$ make testacc TESTARGS='-run=^TestAccAWSOutpostsOutpostDataSource'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=^TestAccAWSOutpostsOutpostDataSource -timeout 120m
=== RUN   TestAccAWSOutpostsOutpostDataSource_Id
=== PAUSE TestAccAWSOutpostsOutpostDataSource_Id
=== RUN   TestAccAWSOutpostsOutpostDataSource_Name
=== PAUSE TestAccAWSOutpostsOutpostDataSource_Name
=== RUN   TestAccAWSOutpostsOutpostDataSource_Arn
=== PAUSE TestAccAWSOutpostsOutpostDataSource_Arn
=== CONT  TestAccAWSOutpostsOutpostDataSource_Id
=== CONT  TestAccAWSOutpostsOutpostDataSource_Arn
=== CONT  TestAccAWSOutpostsOutpostDataSource_Name
--- PASS: TestAccAWSOutpostsOutpostDataSource_Id (41.59s)
--- PASS: TestAccAWSOutpostsOutpostDataSource_Name (46.61s)
--- PASS: TestAccAWSOutpostsOutpostDataSource_Arn (46.78s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       47.897s
...

@johnbarney johnbarney requested a review from a team September 2, 2020 01:18
@ghost ghost added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/outposts Issues and PRs that pertain to the outposts service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Sep 2, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 2, 2020
@bflad bflad added this to the v3.5.0 milestone Sep 2, 2020
@bflad bflad self-assigned this Sep 2, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

@bflad bflad merged commit 3680d46 into hashicorp:master Sep 2, 2020
bflad added a commit that referenced this pull request Sep 2, 2020
@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@johnbarney johnbarney deleted the OutpostsOutpostByArn branch September 11, 2020 07:46
@ghost
Copy link

ghost commented Oct 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2020
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/outposts Issues and PRs that pertain to the outposts service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new argument for data source: aws_outposts_outpost outpost_arn
3 participants