Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_acm_certificate: Prevent tagging is not permitted on re-import error #15060

Merged
merged 1 commit into from
Sep 14, 2020
Merged

resource/aws_acm_certificate: Prevent tagging is not permitted on re-import error #15060

merged 1 commit into from
Sep 14, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 8, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15055

Release note for CHANGELOG:

* resource/aws_acm_certificate: Prevent tagging is not permitted on re-import error

Previously:

=== CONT  TestAccAWSAcmCertificate_PrivateKey_Tags
    resource_aws_acm_certificate_test.go:701: Step 3/3 error: terraform failed: exit status 1

        stderr:

        Error: Error updating certificate: ValidationException: Tagging is not permitted on re-import.

Output from acceptance testing:

--- PASS: TestAccAWSAcmCertificate_disableCTLogging (24.02s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (24.15s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (25.89s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (41.51s)
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (19.16s)
--- PASS: TestAccAWSAcmCertificate_privateCert (26.40s)
--- PASS: TestAccAWSAcmCertificate_PrivateKey_Tags (30.19s)
--- PASS: TestAccAWSAcmCertificate_root (24.82s)
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (2.41s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (23.98s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (24.25s)
--- PASS: TestAccAWSAcmCertificate_san_single (24.21s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (26.33s)
--- PASS: TestAccAWSAcmCertificate_SubjectAlternativeNames_EmptyString (2.40s)
--- PASS: TestAccAWSAcmCertificate_tags (53.81s)
--- PASS: TestAccAWSAcmCertificate_wildcard (22.73s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (23.47s)

@bflad
resource/aws_acm_certificate: Prevent tagging is not permitted on re-…
5fc0721 
…import error

Reference: #15055

Previously:

```
=== CONT  TestAccAWSAcmCertificate_PrivateKey_Tags
    resource_aws_acm_certificate_test.go:701: Step 3/3 error: terraform failed: exit status 1

        stderr:

        Error: Error updating certificate: ValidationException: Tagging is not permitted on re-import.
```

Output from acceptance testing:

```
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (24.02s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (24.15s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (25.89s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (41.51s)
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (19.16s)
--- PASS: TestAccAWSAcmCertificate_privateCert (26.40s)
--- PASS: TestAccAWSAcmCertificate_PrivateKey_Tags (30.19s)
--- PASS: TestAccAWSAcmCertificate_root (24.82s)
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (2.41s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (23.98s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (24.25s)
--- PASS: TestAccAWSAcmCertificate_san_single (24.21s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (26.33s)
--- PASS: TestAccAWSAcmCertificate_SubjectAlternativeNames_EmptyString (2.40s)
--- PASS: TestAccAWSAcmCertificate_tags (53.81s)
--- PASS: TestAccAWSAcmCertificate_wildcard (22.73s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (23.47s)
```
@bflad bflad added the bug Addresses a defect in current functionality. label Sep 8, 2020
@bflad bflad requested a review from a team September 8, 2020 13:49
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/acm Issues and PRs that pertain to the acm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 8, 2020
@bflad bflad mentioned this pull request Sep 8, 2020
Closed
@gdavison gdavison self-assigned this Sep 14, 2020
gdavison
gdavison approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- SKIP: TestAccAWSAcmCertificate_dnsValidation (0.00s)
--- SKIP: TestAccAWSAcmCertificateDataSource_multipleIssued (0.00s)
--- SKIP: TestAccAWSAcmCertificate_root (0.00s)
--- SKIP: TestAccAWSAcmCertificate_root_TrailingPeriod (0.00s)
--- SKIP: TestAccAWSAcmCertificate_emailValidation (0.00s)
--- SKIP: TestAccAWSAcmCertificate_san_single (0.00s)
--- SKIP: TestAccAWSAcmCertificate_wildcard (0.00s)
--- SKIP: TestAccAWSAcmCertificate_wildcardAndRootSan (0.00s)
--- SKIP: TestAccAWSAcmCertificateDataSource_noMatchReturnsError (0.00s)
--- SKIP: TestAccAWSAcmCertificate_san_TrailingPeriod (0.00s)
--- SKIP: TestAccAWSAcmCertificateDataSource_singleIssued (0.00s)
--- SKIP: TestAccAWSAcmCertificateValidation_validationRecordFqdnsSan (0.00s)
--- SKIP: TestAccAWSAcmCertificateValidation_validationRecordFqdnsEmail (0.00s)
--- SKIP: TestAccAWSAcmCertificateValidation_timeout (0.00s)
--- SKIP: TestAccAWSAcmCertificateValidation_validationRecordFqdns (0.00s)
--- SKIP: TestAccAWSAcmCertificate_rootAndWildcardSan (0.00s)
--- SKIP: TestAccAWSAcmCertificate_san_multiple (0.00s)
--- SKIP: TestAccAWSAcmCertificate_disableCTLogging (0.00s)
--- SKIP: TestAccAWSAcmCertificate_SubjectAlternativeNames_EmptyString (0.00s)
--- SKIP: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcardAndRoot (0.00s)
--- SKIP: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcard (0.00s)
--- SKIP: TestAccAWSAcmCertificate_tags (0.00s)
--- SKIP: TestAccAWSAcmCertificateValidation_basic (0.00s)
--- SKIP: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRootAndWildcard (0.00s)
--- SKIP: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRoot (0.00s)
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (22.08s)
--- PASS: TestAccAWSAcmCertificateDataSource_KeyTypes (23.40s)
--- PASS: TestAccAWSAcmCertificate_privateCert (24.63s)
--- PASS: TestAccAWSAcmCertificate_PrivateKey_Tags (33.90s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (45.44s)

@bflad bflad added this to the v3.7.0 milestone Sep 14, 2020
@bflad bflad merged commit eec4f71 into master Sep 14, 2020
@bflad bflad deleted the b-aws_acm_certificate-tagging-on-reimport branch September 14, 2020 18:57
bflad added a commit that referenced this pull request Sep 14, 2020
@bflad
Update CHANGELOG for #15060
c3d69c2
@ghost
Copy link

ghost commented Sep 17, 2020

This has been released in version 3.7.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
bug Addresses a defect in current functionality. service/acm Issues and PRs that pertain to the acm service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

aws_acm_certificate - Tagging is not permitted on re-import.
2 participants
@bflad @gdavison