Update data_source_aws_kms_secrets.go

[zopanix]

This commit will fix the fact that terraform display sensitive information in it's plan when using the data source for KMS Secrets. Plugin API ocmpatibility was not respected.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15157

Release note for CHANGELOG:

fix: Stop displaying sensitive information for kms secrets datasources

[anGie44]

Thanks for the PR @zopanix ! LGTM 🚀

Tested in 0.13:

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
 <= read (data resources)

Terraform will perform the following actions:

  # data.aws_kms_secrets.example will be read during apply
  # (config refers to values not yet known)
 <= data "aws_kms_secrets" "example"  {
      ~ id        = "2020-09-16 16:35:08.590068 +0000 UTC" -> "2020-09-16 16:35:09.717029 +0000 UTC"
        plaintext = (sensitive value)

Tested in 0.12 (no changes from original behavior):

data.aws_kms_secrets.example: Refreshing state...
aws_kms_key.a: Refreshing state... [id=....]

------------------------------------------------------------------------

No changes. Infrastructure is up-to-date.

Output of acceptance test:

--- PASS: TestAccAWSKmsSecretsDataSource_basic (18.46s)

[ghost]

This has been released in version 3.7.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!