Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_cognito_identity_pool: Prevent ordering differences for openid_connect_provider_arns argument #15178

Merged

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 16, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15176

Release note for CHANGELOG:

* resource/aws_cognito_identity_pool: Prevent ordering differences for `openid_connect_provider_arns` argument

Output from acceptance testing:

--- PASS: TestAccAWSCognitoIdentityPool_basic (24.04s)
--- PASS: TestAccAWSCognitoIdentityPool_supportedLoginProviders (31.68s)
--- PASS: TestAccAWSCognitoIdentityPool_cognitoIdentityProviders (32.20s)
--- PASS: TestAccAWSCognitoIdentityPool_tags (33.05s)
--- PASS: TestAccAWSCognitoIdentityPool_openidConnectProviderArns (33.34s)
--- PASS: TestAccAWSCognitoIdentityPool_samlProviderArns (37.66s)

…openid_connect_provider_arns argument

Reference: #15176

Output from acceptance testing:

```
--- PASS: TestAccAWSCognitoIdentityPool_basic (24.04s)
--- PASS: TestAccAWSCognitoIdentityPool_supportedLoginProviders (31.68s)
--- PASS: TestAccAWSCognitoIdentityPool_cognitoIdentityProviders (32.20s)
--- PASS: TestAccAWSCognitoIdentityPool_tags (33.05s)
--- PASS: TestAccAWSCognitoIdentityPool_openidConnectProviderArns (33.34s)
--- PASS: TestAccAWSCognitoIdentityPool_samlProviderArns (37.66s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/cognito labels Sep 16, 2020
@bflad bflad requested a review from a team September 16, 2020 16:25
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Sep 16, 2020
@YakDriver YakDriver assigned YakDriver and unassigned YakDriver Sep 17, 2020
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢

--- PASS: TestAccAWSCognitoIdentityPool_basic (25.64s)
--- PASS: TestAccAWSCognitoIdentityPool_supportedLoginProviders (35.52s)
--- PASS: TestAccAWSCognitoIdentityPool_cognitoIdentityProviders (35.59s)
--- PASS: TestAccAWSCognitoIdentityPool_tags (35.79s)
--- PASS: TestAccAWSCognitoIdentityPool_openidConnectProviderArns (36.36s)
--- PASS: TestAccAWSCognitoIdentityPool_samlProviderArns (36.59s)

@bflad bflad added this to the v3.7.0 milestone Sep 17, 2020
@bflad bflad merged commit c2290a8 into master Sep 17, 2020
@bflad bflad deleted the b-aws_cognito_identity_provider-openid_connect_provider_arns branch September 17, 2020 22:42
bflad added a commit that referenced this pull request Sep 17, 2020
@ghost
Copy link

ghost commented Sep 17, 2020

This has been released in version 3.7.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource/aws_cognito_identity_pool: openid_connect_provider_arns Showing Ordering Differences
2 participants