r/aws_eip: Remove from state on deletion

[radeksimko]

As mentioned in e4244f8#commitcomment-23945540

cc @ksperling

Fixes #1529

TF_ACC=1 go test ./aws -v -run=TestAccAWSEIP_ -timeout 120m
=== RUN   TestAccAWSEIP_importEc2Classic
--- PASS: TestAccAWSEIP_importEc2Classic (138.46s)
=== RUN   TestAccAWSEIP_importVpc
--- PASS: TestAccAWSEIP_importVpc (86.02s)
=== RUN   TestAccAWSEIP_basic
--- PASS: TestAccAWSEIP_basic (27.44s)
=== RUN   TestAccAWSEIP_instance
--- PASS: TestAccAWSEIP_instance (234.09s)
=== RUN   TestAccAWSEIP_network_interface
--- PASS: TestAccAWSEIP_network_interface (83.02s)
=== RUN   TestAccAWSEIP_twoEIPsOneNetworkInterface
--- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (82.75s)
=== RUN   TestAccAWSEIP_associated_user_private_ip
--- PASS: TestAccAWSEIP_associated_user_private_ip (230.20s)
=== RUN   TestAccAWSEIP_classic_disassociate
--- PASS: TestAccAWSEIP_classic_disassociate (285.29s)
=== RUN   TestAccAWSEIP_disappears
--- PASS: TestAccAWSEIP_disappears (20.59s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1187.911s

[Ninir]

Looks good to me!
(Closed mine an hour ago or so, that was doing the same thing, without the tests, which I admit are a nice way to check this specific use-case!)

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSEIP -timeout 120m
=== RUN   TestAccAWSEIPAssociation_basic
--- PASS: TestAccAWSEIPAssociation_basic (230.76s)
=== RUN   TestAccAWSEIPAssociation_ec2Classic
--- FAIL: TestAccAWSEIPAssociation_ec2Classic (113.25s)
	testing.go:435: Step 0 error: Check failed: Check 4/5 error: aws_eip_association.test: Attribute 'allocation_id' expected "", got "eipalloc-4baead78"
=== RUN   TestAccAWSEIPAssociation_disappears
--- PASS: TestAccAWSEIPAssociation_disappears (168.70s)
=== RUN   TestAccAWSEIP_importEc2Classic
--- FAIL: TestAccAWSEIP_importEc2Classic (89.89s)
	testing.go:435: Step 1 error: 1 error(s) occurred:
		
		* aws_eip.bar (import id: eipalloc-10acaf23): 1 error(s) occurred:
		
		* import aws_eip.bar result: eipalloc-10acaf23: import aws_eip.bar (id: eipalloc-10acaf23): Terraform detected a resource with this ID doesn't
		exist. Please verify the ID is correct. You cannot import non-existent
		resources using Terraform import.
=== RUN   TestAccAWSEIP_importVpc
--- PASS: TestAccAWSEIP_importVpc (106.11s)
=== RUN   TestAccAWSEIP_basic
--- PASS: TestAccAWSEIP_basic (33.29s)
=== RUN   TestAccAWSEIP_instance
--- PASS: TestAccAWSEIP_instance (246.60s)
=== RUN   TestAccAWSEIP_network_interface
--- PASS: TestAccAWSEIP_network_interface (102.19s)
=== RUN   TestAccAWSEIP_twoEIPsOneNetworkInterface
--- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (103.07s)
=== RUN   TestAccAWSEIP_associated_user_private_ip
--- PASS: TestAccAWSEIP_associated_user_private_ip (280.14s)
=== RUN   TestAccAWSEIP_classic_disassociate
--- PASS: TestAccAWSEIP_classic_disassociate (347.22s)
=== RUN   TestAccAWSEIP_disappears
--- PASS: TestAccAWSEIP_disappears (24.80s)
FAIL
exit status 1
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	1846.058s
make: *** [testacc] Error 1

Tests may seem related. Would you have time to investigate a bit?

[radeksimko]

My tests all passed - I believe you see those failures because your AWS account is completely VPC-based?

We have a region with EC2 Classic enabled (us-east-1). I guess it would be less confusing if we actually checked supported platforms as part of those tests and skipped them in case EC2 Classic isn't available.

[Ninir]

My tests all passed - I believe you see those failures because your AWS account is completely VPC-based?

It is.

We have a region with EC2 Classic enabled (us-east-1). I guess it would be less confusing if we actually checked supported platforms as part of those tests and skipped them in case EC2 Classic isn't available.

Probably for your idea. However, feel free to merge as I don't really have time to update this on my side.

[radeksimko]

See #1566 - that should let you skip the EC2 Classic tests and make the whole mentioned suite pass.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!