Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data_source/aws_vpc_endpoint: Exposing prefix_list_id in datasource #1733

Merged
merged 1 commit into from
Oct 5, 2017
Merged

data_source/aws_vpc_endpoint: Exposing prefix_list_id in datasource #1733

merged 1 commit into from
Oct 5, 2017

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Sep 23, 2017

Fixes: #1691

terraform-provider-aws [b-aws-vpce-ds-1691●] % acctests aws TestAccDataSourceAwsVpcEndpoint_
=== RUN   TestAccDataSourceAwsVpcEndpoint_basic
--- PASS: TestAccDataSourceAwsVpcEndpoint_basic (60.06s)
=== RUN   TestAccDataSourceAwsVpcEndpoint_withRouteTable
--- PASS: TestAccDataSourceAwsVpcEndpoint_withRouteTable (64.76s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	124.860s

@stack72
data_source/aws_vpc_endpoint: Exposing prefix_list_id in datasource
6a9dd21 
Fixes: hashicorp#1691

```
terraform-provider-aws [b-aws-vpce-ds-1691●] % acctests aws TestAccDataSourceAwsVpcEndpoint_
=== RUN   TestAccDataSourceAwsVpcEndpoint_basic
--- PASS: TestAccDataSourceAwsVpcEndpoint_basic (60.06s)
=== RUN   TestAccDataSourceAwsVpcEndpoint_withRouteTable
--- PASS: TestAccDataSourceAwsVpcEndpoint_withRouteTable (64.76s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	124.860s
```
@radeksimko
Copy link
Member

Hey @stack72
is there any particular reason why we should expose the first prefix ID instead of all? i.e. why should this field be different to route_table_ids?

@radeksimko radeksimko added enhancement Requests to existing resources that expand the functionality or scope. waiting-response Maintainers are waiting on response from community or contributor. labels Sep 27, 2017
@stack72
Copy link
Contributor Author

stack72 commented Sep 27, 2017

@radeksimko I followed the same code as aws_vpc_endpoint which only exposes the first. As this is the data source of the resource, I thought it should work the same

@stack72
Copy link
Contributor Author

stack72 commented Oct 4, 2017

@radeksimko ping on this one - thoughts?

@radeksimko radeksimko removed the waiting-response Maintainers are waiting on response from community or contributor. label Oct 5, 2017
radeksimko
radeksimko approved these changes Oct 5, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Thanks for the explanation.

@radeksimko radeksimko merged commit c978648 into hashicorp:master Oct 5, 2017
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_vpc_endpoint data source does not expose prefix_list_id, but the equivalent resource does
2 participants
@stack72 @radeksimko