-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'arn' attribute to 'aws_redshift_service_account' data source #1775
Add 'arn' attribute to 'aws_redshift_service_account' data source #1775
Conversation
|
@@ -45,6 +49,7 @@ func dataSourceAwsRedshiftServiceAccountRead(d *schema.ResourceData, meta interf | |||
|
|||
if accid, ok := redshiftServiceAccountPerRegionMap[region]; ok { | |||
d.SetId(accid) | |||
d.Set("arn", fmt.Sprintf("arn:%s:iam::%s:user/logs", meta.(*AWSClient).partition, accid)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should use fmt.Sprintf here - I think we should use the ARN package as part of AWS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
Added
|
@ewbankkit this looks much nicer without the |
@stack72 Anything more you need me to do on this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ewbankkit
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Similar to hashicorp/terraform#8700 for the
aws_elb_service_account
data source, add thearn
attribute to theaws_redshift_service_account
data source.Acceptance tests: