Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_cloudwatch_log_resource_policy #2243

Merged
merged 1 commit into from
Dec 6, 2017
Merged

New Resource: aws_cloudwatch_log_resource_policy #2243

merged 1 commit into from
Dec 6, 2017

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 10, 2017

Required for supporting Route53 query logging.

make testacc TESTARGS='-run=TestAccAWSCloudWatchLogResourcePolicy'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccAWSCloudWatchLogResourcePolicy -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCloudWatchLogResourcePolicy_Basic
--- PASS: TestAccAWSCloudWatchLogResourcePolicy_Basic (21.21s)
=== RUN   TestAccAWSCloudWatchLogResourcePolicy_Import
--- PASS: TestAccAWSCloudWatchLogResourcePolicy_Import (12.79s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	34.029s

Reference: #1764

@bflad bflad mentioned this pull request Nov 10, 2017
Closed
@Ninir Ninir added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 10, 2017
@radeksimko radeksimko added the size/L Managed by automation to categorize the size of a PR. label Nov 15, 2017
@bflad bflad mentioned this pull request Nov 17, 2017
Closed
@bflad
Copy link
Contributor Author

bflad commented Nov 27, 2017

Can I please get an initial review of this PR? Thanks!

radeksimko
radeksimko approved these changes Dec 6, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Thanks.

@radeksimko radeksimko merged commit 8cf1d04 into hashicorp:master Dec 6, 2017
@radeksimko radeksimko mentioned this pull request Dec 6, 2017
Merged
@bflad bflad deleted the aws_cloudwatch_logs_resource_policy branch December 6, 2017 21:32
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bflad @radeksimko @Ninir