Add arn attribute to aws_elb resource #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
reviewed
Nov 15, 2017
aws/resource_aws_elb.go
Outdated
| @@ -44,6 +45,12 @@ func resourceAwsElb() *schema.Resource { | |||
| ValidateFunc: validateElbNamePrefix, | |||
| }, | |||
|
|
|||
| "arn": &schema.Schema{ | |||
| Type: schema.TypeString, | |||
| Optional: true, | |||
There was a problem hiding this comment.
Any particular reason why it should be optional? i.e. why would the user need to define it in the config?
There was a problem hiding this comment.
Ah sorry, delicious copypasta. It should probably always be just Computed.
radeksimko
added
enhancement
|
Pushed update to remove |
radeksimko
removed
the
waiting-response
radeksimko
approved these changes
Nov 15, 2017
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not provided directly by DescribeLoadBalancers/DescribeLoadBalancerAttributes APIs, so built manually. References:
Closes #2123
I cannot run
TestAccAWSELB_basicsince the default VPC has been removed from my own AWS account, but these are similar changes as #2271.