r/ecs_task_definition: Fix equivalency comparator

[radeksimko]

Closes #2336

@ziggythehamster @nathanielks @achille-roussel @bturbes - do you folks mind testing this with your configs and/or pasting it here so we can test it to make sure the bug doesn't re-appear?

Test results

TF_ACC=1 go test ./aws -v -run=TestAccAWSEcsTaskDefinition -timeout 120m
=== RUN   TestAccAWSEcsTaskDefinition_basic
--- PASS: TestAccAWSEcsTaskDefinition_basic (57.24s)
=== RUN   TestAccAWSEcsTaskDefinition_withScratchVolume
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (35.02s)
=== RUN   TestAccAWSEcsTaskDefinition_withEcsService
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (149.91s)
=== RUN   TestAccAWSEcsTaskDefinition_withTaskRoleArn
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (38.40s)
=== RUN   TestAccAWSEcsTaskDefinition_withNetworkMode
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (66.97s)
=== RUN   TestAccAWSEcsTaskDefinition_constraint
--- PASS: TestAccAWSEcsTaskDefinition_constraint (33.79s)
=== RUN   TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
--- PASS: TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource (55.91s)
=== RUN   TestAccAWSEcsTaskDefinition_arrays
--- PASS: TestAccAWSEcsTaskDefinition_arrays (34.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	471.371s

[ziggythehamster]

I'm happy to test - how do I go about doing that?

[radeksimko]

@ziggythehamster Try cloning the repository and building the binary locally: https://github.com/terraform-providers/terraform-provider-aws#building-the-provider

then in the directory with your ECS configs just rm -rf ./.terraform && terraform init to load the new binary and carry on with terraform plan which should present no diff.

Eventually I can try and build it for your platform if you tell me more about your environment - i.e. architecture & OS.

[catsby]

👍 one logging nit/suggestion

[catsby]

nit: not sure if this is debugging that you left in unintentionally, however if intended, maybe we should log instead the result of the compare; logical match or difference etc. Right here we're just logging both and not actually saying if Terraform seems them as equal, that's left up to the user debugger

[radeksimko]

right, good point - I'm happy to add more context (i.e. whether it's a match).

The reason I left it there is because I had hard times comparing those JSONs in a failing test, where you can only get the original (non-canonical) JSONs which is also kind of intention, because this process should remain hidden as implementation detail.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!