r/aws_lb_target_group: various fixes to behavior based on protocol type #2380

catsby · 2017-11-20T19:45:35Z

This PR includes a number of fixes and adjustments for working with Application and Network Load Balancers. Specifically, some items in #2251 had their defaults removed, others changed.

Here we guard against setting certain health check attributes for network load balancers, et. al, and mark other fields as computed.

The rules are unfortunately complicated:

http://docs.aws.amazon.com/elasticloadbalancing/latest/APIReference/API_CreateTargetGroup.html

Fixes / related:

aws_lb_target_group health_check.0.matcher no longer defaults to 200 #2327, Incorrect documentation for lb_target_group #2343

Test results:

TF_ACC=1 go test ./aws -v -run=TestAccAWSLBTargetGroup_ -timeout 120m
=== RUN   TestAccAWSLBTargetGroup_basic
--- PASS: TestAccAWSLBTargetGroup_basic (23.48s)
=== RUN   TestAccAWSLBTargetGroup_networkLB_TargetGroup
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (43.68s)
=== RUN   TestAccAWSLBTargetGroup_namePrefix
--- PASS: TestAccAWSLBTargetGroup_namePrefix (22.23s)
=== RUN   TestAccAWSLBTargetGroup_generatedName
--- PASS: TestAccAWSLBTargetGroup_generatedName (22.28s)
=== RUN   TestAccAWSLBTargetGroup_changeNameForceNew
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (38.19s)
=== RUN   TestAccAWSLBTargetGroup_changeProtocolForceNew
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (44.55s)
=== RUN   TestAccAWSLBTargetGroup_changePortForceNew
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (37.90s)
=== RUN   TestAccAWSLBTargetGroup_changeVpcForceNew
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (38.93s)
=== RUN   TestAccAWSLBTargetGroup_tags
--- PASS: TestAccAWSLBTargetGroup_tags (37.78s)
=== RUN   TestAccAWSLBTargetGroup_updateHealthCheck
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (37.99s)
=== RUN   TestAccAWSLBTargetGroup_updateSticknessEnabled
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (55.36s)
=== RUN   TestAccAWSLBTargetGroup_defaults_application
--- PASS: TestAccAWSLBTargetGroup_defaults_application (21.98s)
=== RUN   TestAccAWSLBTargetGroup_defaults_network
--- PASS: TestAccAWSLBTargetGroup_defaults_network (26.25s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       450.653s

Ninir

Looks good to me 👍

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSLBTargetGroup_'  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSLBTargetGroup_ -timeout 120m
=== RUN   TestAccAWSLBTargetGroup_basic
--- PASS: TestAccAWSLBTargetGroup_basic (27.70s)
=== RUN   TestAccAWSLBTargetGroup_networkLB_TargetGroup
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (84.74s)
=== RUN   TestAccAWSLBTargetGroup_namePrefix
--- PASS: TestAccAWSLBTargetGroup_namePrefix (19.04s)
=== RUN   TestAccAWSLBTargetGroup_generatedName
--- PASS: TestAccAWSLBTargetGroup_generatedName (22.38s)
=== RUN   TestAccAWSLBTargetGroup_changeNameForceNew
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (34.49s)
=== RUN   TestAccAWSLBTargetGroup_changeProtocolForceNew
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (38.82s)
=== RUN   TestAccAWSLBTargetGroup_changePortForceNew
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (34.36s)
=== RUN   TestAccAWSLBTargetGroup_changeVpcForceNew
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (33.45s)
=== RUN   TestAccAWSLBTargetGroup_tags
--- PASS: TestAccAWSLBTargetGroup_tags (33.30s)
=== RUN   TestAccAWSLBTargetGroup_updateHealthCheck
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (33.94s)
=== RUN   TestAccAWSLBTargetGroup_updateSticknessEnabled
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (47.48s)
=== RUN   TestAccAWSLBTargetGroup_defaults_application
--- PASS: TestAccAWSLBTargetGroup_defaults_application (20.78s)
=== RUN   TestAccAWSLBTargetGroup_defaults_network
--- PASS: TestAccAWSLBTargetGroup_defaults_network (24.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	455.442s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSELB_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSELB_ -timeout 120m
=== RUN   TestAccAWSELB_importBasic
--- PASS: TestAccAWSELB_importBasic (42.61s)
=== RUN   TestAccAWSELB_basic
--- PASS: TestAccAWSELB_basic (37.88s)
=== RUN   TestAccAWSELB_fullCharacterRange
--- PASS: TestAccAWSELB_fullCharacterRange (34.60s)
=== RUN   TestAccAWSELB_AccessLogs_enabled
--- PASS: TestAccAWSELB_AccessLogs_enabled (151.74s)
=== RUN   TestAccAWSELB_AccessLogs_disabled
--- PASS: TestAccAWSELB_AccessLogs_disabled (161.91s)
=== RUN   TestAccAWSELB_namePrefix
--- PASS: TestAccAWSELB_namePrefix (34.22s)
=== RUN   TestAccAWSELB_generatedName
--- PASS: TestAccAWSELB_generatedName (35.90s)
=== RUN   TestAccAWSELB_generatesNameForZeroValue
--- PASS: TestAccAWSELB_generatesNameForZeroValue (34.40s)
=== RUN   TestAccAWSELB_availabilityZones
--- PASS: TestAccAWSELB_availabilityZones (60.47s)
=== RUN   TestAccAWSELB_tags
--- PASS: TestAccAWSELB_tags (61.60s)
=== RUN   TestAccAWSELB_iam_server_cert
--- PASS: TestAccAWSELB_iam_server_cert (49.01s)
=== RUN   TestAccAWSELB_swap_subnets
--- PASS: TestAccAWSELB_swap_subnets (130.52s)
=== RUN   TestAccAWSELB_InstanceAttaching
--- PASS: TestAccAWSELB_InstanceAttaching (186.00s)
=== RUN   TestAccAWSELB_HealthCheck
--- PASS: TestAccAWSELB_HealthCheck (36.92s)
=== RUN   TestAccAWSELB_Timeout
--- PASS: TestAccAWSELB_Timeout (36.34s)
=== RUN   TestAccAWSELB_ConnectionDraining
--- PASS: TestAccAWSELB_ConnectionDraining (32.51s)
=== RUN   TestAccAWSELB_SecurityGroups
--- PASS: TestAccAWSELB_SecurityGroups (68.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1195.144s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSALBTargetGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSALBTargetGroup_ -timeout 120m
=== RUN   TestAccAWSALBTargetGroup_basic
--- PASS: TestAccAWSALBTargetGroup_basic (56.86s)
=== RUN   TestAccAWSALBTargetGroup_namePrefix
--- PASS: TestAccAWSALBTargetGroup_namePrefix (52.85s)
=== RUN   TestAccAWSALBTargetGroup_generatedName
--- PASS: TestAccAWSALBTargetGroup_generatedName (63.26s)
=== RUN   TestAccAWSALBTargetGroup_changeNameForceNew
--- PASS: TestAccAWSALBTargetGroup_changeNameForceNew (92.05s)
=== RUN   TestAccAWSALBTargetGroup_changeProtocolForceNew
--- FAIL: TestAccAWSALBTargetGroup_changeProtocolForceNew (63.23s)
	testing.go:503: Step 1 error: Error applying: 1 error(s) occurred:
		
		* aws_vpc.test2: 1 error(s) occurred:
		
		* aws_vpc.test2: Error creating VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
			status code: 400, request id: 23df6f53-e792-41f9-9835-bcc0837a0c2d
=== RUN   TestAccAWSALBTargetGroup_changePortForceNew
--- PASS: TestAccAWSALBTargetGroup_changePortForceNew (91.91s)
=== RUN   TestAccAWSALBTargetGroup_changeVpcForceNew
--- PASS: TestAccAWSALBTargetGroup_changeVpcForceNew (83.08s)
=== RUN   TestAccAWSALBTargetGroup_tags
--- PASS: TestAccAWSALBTargetGroup_tags (89.42s)
=== RUN   TestAccAWSALBTargetGroup_updateHealthCheck
--- PASS: TestAccAWSALBTargetGroup_updateHealthCheck (88.38s)
=== RUN   TestAccAWSALBTargetGroup_updateSticknessEnabled
--- PASS: TestAccAWSALBTargetGroup_updateSticknessEnabled (124.21s)
FAIL
exit status 1
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	805.318s
make: *** [testacc] Error 1

(errors are not about those tests)

mblakele · 2017-11-20T23:15:28Z

website/docs/r/lb_target_group.html.markdown

 * `healthy_threshold` - (Optional) The number of consecutive health checks successes required before considering an unhealthy target healthy. Defaults to 5.
 * `unhealthy_threshold` - (Optional) The number of consecutive health check failures required before considering the target unhealthy. Defaults to 2.
-* `matcher` (Optional) The HTTP codes to use when checking for a successful response from a target. Defaults to `200`. You can specify multiple values (for example, "200,202") or a range of values (for example, "200-299").
+* `matcher` (Optiona, only supported on Application Load Balancers): The HTTP codes to use when checking for a successful response from a target. You can specify multiple values (for example, "200,202") or a range of values (for example, "200-299").


s/Optiona/Optional/

danstepanov · 2017-12-02T22:59:36Z

Anything I can do to help resolve the merge conflicts here to get this PR merged?

igordavid · 2017-12-06T15:31:36Z

Hello,

Are there any updates for this one?

$ terraform_0.11.1 --version
Terraform v0.11.1

provider.aws v1.5.0
provider.template v1.0.0

There are still issues when trying to use aws_lb_target_group:

Error:

aws_lb_target_group.NLB-TARGET-GROUP-HTTP: Error creating LB Target Group: ValidationError: Health check matcher HTTP code cannot be empty

module.mesg_nlb2.aws_lb_target_group.NLB-TARGET-GROUP-HTTP: 1 error(s) occurred:

aws_lb_target_group.NLB-TARGET-GROUP-HTTP: Error creating LB Target Group: ValidationError: Health check matcher HTTP code cannot be empty

This is how I configured aws_lb_target_group:

resource "aws_lb_target_group" "NLB-TARGET-GROUP-HTTP" {
  name = "NLB-${var.environment}-TG-MESG-HTTP"
  port     = 80
  protocol = "HTTP"
  vpc_id   = "${var.vpc_id}"
  health_check {
  interval = 10
  path = "/"
  timeout = 5
  healthy_threshold = 3
}
}

catsby · 2017-12-14T21:29:45Z

I've rebased to fix the merge conflict. I'm re-running tests and will update the original post with the results. The conflict was in Docs so if the tests pass again I'll go ahead and merge

catsby · 2017-12-14T22:20:26Z

Tests pass, so I'm going to merge this!

ghost · 2020-04-10T17:16:15Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

catsby requested a review from Ninir November 20, 2017 19:45

This was referenced Nov 20, 2017

r/lb_target_group: fix compatibility with Network Load Balancers #2251

Merged

aws_lb_target_group health_check.0.matcher no longer defaults to 200 #2327

Closed

Ninir approved these changes Nov 20, 2017

View reviewed changes

mblakele reviewed Nov 20, 2017

View reviewed changes

catsby changed the title ~~r/aws_lb_target_group~~ r/aws_lb_target_group: various fixes to behavior based on protocol type Nov 21, 2017

radeksimko added the bug Addresses a defect in current functionality. label Nov 30, 2017

catsby added 8 commits December 14, 2017 15:27

fix up nlb/alb issues

0c1d404

add a regression test that supports HTTP defaults

9702863

cleanups from bad stash / pop

cccf0c0

don't save empty stickness map to state

ae4f9e4

regression / acceptance tests

0b0ecc4

fix vet issue

e0457e8

matcher is optional, not required

c429ea5

fix typo

32cf8ab

catsby force-pushed the b-aws-lb-target-group-fixes branch from f03385e to 32cf8ab Compare December 14, 2017 21:28

go fmt

1220ec1

catsby merged commit a6d1266 into master Dec 14, 2017

catsby deleted the b-aws-lb-target-group-fixes branch December 14, 2017 22:20

wvidana mentioned this pull request Dec 19, 2017

ALB target group defaults changed for healthy/unhealthy thresholds #2712

Closed

This was referenced Dec 20, 2017

Unable to define http/s health checks for Network Loadbalancer #2708

Closed

HTTP health check not working with NLB #2653

Closed

atsushi-ishibashi mentioned this pull request Dec 31, 2017

r/lb_target_group: Use default(200) when matcher isn't specified #2676

Closed

ghost locked and limited conversation to collaborators Apr 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_lb_target_group: various fixes to behavior based on protocol type #2380

r/aws_lb_target_group: various fixes to behavior based on protocol type #2380

catsby commented Nov 20, 2017 •

edited

Loading

Ninir left a comment

mblakele Nov 20, 2017

danstepanov commented Dec 2, 2017

igordavid commented Dec 6, 2017

catsby commented Dec 14, 2017

catsby commented Dec 14, 2017

ghost commented Apr 10, 2020

r/aws_lb_target_group: various fixes to behavior based on protocol type #2380

r/aws_lb_target_group: various fixes to behavior based on protocol type #2380

Conversation

catsby commented Nov 20, 2017 • edited Loading

Ninir left a comment

Choose a reason for hiding this comment

mblakele Nov 20, 2017

Choose a reason for hiding this comment

danstepanov commented Dec 2, 2017

igordavid commented Dec 6, 2017

catsby commented Dec 14, 2017

catsby commented Dec 14, 2017

ghost commented Apr 10, 2020

catsby commented Nov 20, 2017 •

edited

Loading