Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/elasticache_replication_group: Modify validation, make replication_group_id to lowercase #2432

Merged
merged 1 commit into from
Dec 2, 2017
Merged

r/elasticache_replication_group: Modify validation, make replication_group_id to lowercase #2432

merged 1 commit into from
Dec 2, 2017

Conversation

atsushi-ishibashi
Copy link
Contributor 

make testacc TEST=./aws TESTARGS='-run=TestAccAWSElasticacheReplicationGroup_Uppercase'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSElasticacheReplicationGroup_Uppercase -timeout 120m
=== RUN   TestAccAWSElasticacheReplicationGroup_Uppercase
--- PASS: TestAccAWSElasticacheReplicationGroup_Uppercase (660.74s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	661.043s

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Nov 30, 2017
radeksimko
radeksimko approved these changes Dec 2, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@radeksimko radeksimko merged commit 5138547 into hashicorp:master Dec 2, 2017
@atsushi-ishibashi atsushi-ishibashi deleted the lowercase-elasticache_rg branch December 13, 2017 15:15
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atsushi-ishibashi @radeksimko