resource/aws_network_acl_rule: Fix DiffSuppressFunc

[enm10k]

Reference #222

The following issue was already closed but it's only for one protocol.
Now the bug is not fixed for other protocols.
This code will fix it.
issue: hashicorp/terraform#13012
pr: hashicorp/terraform#13049

This is "best effort" implementations of acceptance tests.
I hope Terraform team will check this pr.

Thanks.

[enm10k]

@radeksimko
I read #222 again and now I understood this problem is not only for aws_network_acl_rule.
If anyone reviews my changes, I'll check these other resources: aws_noetwork_acl, aws_security_group, aws_security_group_rule.
I want to fix this function for my use.

[bflad]

Thanks so much, @enm10k! 🚀

--- PASS: TestAccAWSNetworkAclRule_ipv6 (7.07s)
--- PASS: TestAccAWSNetworkAclRule_allProtocol (12.26s)
--- PASS: TestAccAWSNetworkAclRule_missingParam (15.60s)
--- PASS: TestAccAWSNetworkAclRule_tcpProtocol (11.17s)
--- PASS: TestAccAWSNetworkAclRule_basic (26.18s)
--- PASS: TestAccAWSNetworkAclRule_deleteRule (25.37s)

[bflad]

This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!