d/aws_iam_server_certificate: add support for retrieving public key #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ninir
approved these changes
Dec 22, 2017
There was a problem hiding this comment.
Hi @trung
This looks very good, thanks for the work!
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSourceIAMServerCertificate_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSDataSourceIAMServerCertificate_ -timeout 120m
=== RUN TestAccAWSDataSourceIAMServerCertificate_basic
--- PASS: TestAccAWSDataSourceIAMServerCertificate_basic (27.59s)
=== RUN TestAccAWSDataSourceIAMServerCertificate_matchNamePrefix
--- PASS: TestAccAWSDataSourceIAMServerCertificate_matchNamePrefix (3.95s)
PASS
ok github.com/terraform-providers/terraform-provider-aws-clone/aws 31.594s
Just left a nitpick to address before merging, ensuring every new attribute is well set. 🚀
| @@ -57,6 +57,7 @@ func TestAccAWSDataSourceIAMServerCertificate_basic(t *testing.T) { | |||
| resource.TestCheckResourceAttrSet("data.aws_iam_server_certificate.test", "id"), | |||
| resource.TestCheckResourceAttrSet("data.aws_iam_server_certificate.test", "name"), | |||
| resource.TestCheckResourceAttrSet("data.aws_iam_server_certificate.test", "path"), | |||
| resource.TestMatchResourceAttr("data.aws_iam_server_certificate.test", "certificate_body", regexp.MustCompile("^-----BEGIN CERTIFICATE-----")), | |||
There was a problem hiding this comment.
Can you also add the check for upload_date & certificate_chain?
Ninir
reviewed
Dec 22, 2017
| @@ -10,6 +10,7 @@ import ( | |||
| "github.com/aws/aws-sdk-go/service/iam" | |||
| "github.com/hashicorp/errwrap" | |||
| "github.com/hashicorp/terraform/helper/schema" | |||
| "time" | |||
There was a problem hiding this comment.
Nitpick: can you also move that line 8 also? 😄
Ninir
added
waiting-response
|
thanks @Ninir, refactored per your comments and reran the tests |
|
|
Hey @trung Looks good to me! Thanks for the work! :) 🚀 |
|
This has been released in terraform-provider-aws version 1.7.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
breathingdust
removed
the
waiting-response
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoke API_GetServerCertificate to obtain additional information for server certificate. Among which,
certificate_bodyis useful when configuring back-end instance authentication withaws_load_balancer_policyandaws_load_balancer_backend_server_policyAlso fix the date format to be RFC-compliant
For #2742