Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes skipped min_capacity argument in scalable_target_action #2794

Conversation

dada-amater
Copy link
Contributor

This simple PF fixes variable assignment.

The result of code:

resource "aws_appautoscaling_target" "target" {
    ....
    scalable_target_action {
        min_capacity = 1
        max_capacity = 100
  }
}

was

{
    "ScheduledActions": [
        {
           .... 
           "ScalableTargetAction": {
                "MaxCapacity": 1
            }
        }
    ]
}

@jen20 jen20 added the bug Addresses a defect in current functionality. label Dec 29, 2017
Copy link
Contributor

@jen20 jen20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dada-amater! This fix looks correct to me.

@jen20 jen20 merged commit 1c732b9 into hashicorp:master Dec 29, 2017
@bflad bflad added this to the v1.7.0 milestone Jan 12, 2018
@bflad
Copy link
Contributor

bflad commented Jan 12, 2018

This has been released in terraform-provider-aws version 1.7.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants