Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_s3_bucket_policy: set the resource ID after successful creation #2820

Merged
merged 1 commit into from
Jan 2, 2018
Merged

r/aws_s3_bucket_policy: set the resource ID after successful creation #2820

merged 1 commit into from
Jan 2, 2018

Conversation

sjauld
Copy link
Contributor

@sjauld sjauld commented Jan 2, 2018

Fixes #2819

.../terraform-provider-aws % TF_ACC=1 go test -v ./... -run TestAccAWSS3BucketPolicy
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSS3BucketPolicy_basic
--- PASS: TestAccAWSS3BucketPolicy_basic (76.41s)
=== RUN   TestAccAWSS3BucketPolicy_policyUpdate
--- PASS: TestAccAWSS3BucketPolicy_policyUpdate (119.79s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	196.242s

@sjauld sjauld changed the title Set the resource ID after successful creation r/aws_s3_bucket_policy: set the resource ID after successful creation Jan 2, 2018
@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Jan 2, 2018
radeksimko
radeksimko approved these changes Jan 2, 2018
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sjauld

LGTM 👍

@radeksimko radeksimko merged commit 86502f0 into hashicorp:master Jan 2, 2018
@bflad
Copy link
Contributor

bflad commented Jan 12, 2018

This has been released in terraform-provider-aws version 1.7.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@bflad bflad added this to the v1.7.0 milestone Jan 12, 2018
@sjauld sjauld deleted the 2819-aws_s3_bucket_policy_derp branch November 1, 2018 22:15
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

aws_s3_bucket_policy saves resource to state even if 400 error received
3 participants
@sjauld @bflad @radeksimko