Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/ebs_snapshot: Add support for tags #3

Merged
merged 3 commits into from
Jun 9, 2017
Merged

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Jun 9, 2017

Adds support for tags to aws_ebs_snapshot resource. Originally hashicorp/terraform#15203

@catsby catsby added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 9, 2017
@sethvargo
Copy link
Contributor

Hi @catsby

Thank you for the Pull Request. This change looks really good, but there appears to be some tabs-vs-spaces going on in some of the test fixtures and examples. I don't think we'll be able to merge this until those are fixed :trollface:

@grubernaut
Copy link
Contributor

@sethvargo

@catsby catsby merged commit b0d4180 into master Jun 9, 2017
@sethvargo sethvargo deleted the f-aws-snapshot-tags branch June 9, 2017 19:09
@ghost ghost mentioned this pull request Oct 10, 2017
bflad pushed a commit that referenced this pull request Oct 30, 2019
j-nix referenced this pull request in Omarimcblack/terraform-provider-aws Dec 30, 2019
Tests for TGW peering attachment
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants