resource/aws_iam_user_policy: Fix updates with generated policy names and validate JSON #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and validate JSON This also refactors the acceptance testing to check attributes and reuse test configurations.
bflad
added
bug
radeksimko
approved these changes
Jan 18, 2018
aws/resource_aws_iam_user_policy.go
Outdated
| @@ -57,7 +59,9 @@ func resourceAwsIamUserPolicyPut(d *schema.ResourceData, meta interface{}) error | |||
| } | |||
|
|
|||
| var policyName string | |||
| if v, ok := d.GetOk("name"); ok { | |||
| if d.Id() != "" { | |||
There was a problem hiding this comment.
Nitpick: For folks who're not familiar with the significance of ID so using !d.IsNewResource() may be easier to understand for the reader here.
There was a problem hiding this comment.
Certainly easier to grok! Works like a charm 🚀
make testacc TEST=./aws TESTARGS='-run=TestAccAWSIAMUserPolicy'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSIAMUserPolicy -timeout 120m
=== RUN TestAccAWSIAMUserPolicy_basic
--- PASS: TestAccAWSIAMUserPolicy_basic (15.01s)
=== RUN TestAccAWSIAMUserPolicy_namePrefix
--- PASS: TestAccAWSIAMUserPolicy_namePrefix (15.87s)
=== RUN TestAccAWSIAMUserPolicy_generatedName
--- PASS: TestAccAWSIAMUserPolicy_generatedName (12.56s)
=== RUN TestAccAWSIAMUserPolicy_multiplePolicies
--- PASS: TestAccAWSIAMUserPolicy_multiplePolicies (26.00s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 69.492s
…d.Id() value for readability
|
This has been released in terraform-provider-aws version 1.7.1. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
drewsonne
pushed a commit
to drewsonne/terraform-provider-aws
that referenced
this pull request
Mar 3, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces bugfix portions of #2450
Closes #781
This also refactors the acceptance testing to check attributes, test policy updates for name/name_prefix/generated names, and starts to reuse test configurations where possible (e.g
testAccAWSUserConfigfromaws_iam_usertests).