resource/aws_lambda_function: Recompute Lambda function version and qualified_arn on publish #3032

mdlavin · 2018-01-17T19:02:28Z

This change will cause the lambda function publishes to correctly trigger version updates that will affect downstream resources.

Fixes #626, #2915, #1124 and #3192

mdlavin · 2018-01-18T01:15:27Z

@apparentlymart I'm not sure how the labels are used, but I wouldn't consider this an enhancement. The current behavior without this change means that resources that depend on the version attribute do not correct updates when a new Lambda function version is published. Both of the issues that this fixes are labeled as bugs.

ChristopherGAndrews · 2018-01-18T05:46:59Z

aws/resource_aws_lambda_function.go

 	}
 }

+func updateVerionIfPublish(d *schema.ResourceDiff, meta interface{}) error {
+	publish := d.Get("publish").(bool)
+	if publish && needsFunctionCodeUpdate(d) {


There are two other attributes that need to be SetNewComputed:

last_modified - This need to be recomputed any time there is a change to the Lambda code, even if publish =false

qualified_arn - This needs to be updated only if publish = true

Thank you for the feedback. I implemented the changes for last_modified and qualified_arn. In this version I only updated last_modified during the publish, but I see your point about it being needed more often than that.

…blish

…ed on publish

tmthrgd · 2018-01-18T14:58:13Z

Won't this also fix #1124? (I've been hitting that bug).

mdlavin · 2018-01-18T15:05:58Z

Yes, I think you're right that these changes will fix #1124. I missed that issue.

ChristopherGAndrews · 2018-01-18T16:57:00Z

aws/resource_aws_lambda_function.go

 	}
 }

+func updateComputedAttributesOnPublish(d *schema.ResourceDiff, meta interface{}) error {
+	publish := d.Get("publish").(bool)
+	if publish && needsFunctionCodeUpdate(d) {


What if you did the following. It would make sure the last_modified was updated even if publish is set to false.

if needsFunctionCodeUpdate(d) { d.SetNewComputed("last_modified") if publish { d.SetNewComputed("version") d.SetNewComputed("qualified_arn") } }

Check out the new commit. It should cover your scenario now too

mdlavin · 2018-01-18T17:27:00Z

I like that improvement. It should be pretty easy to make that change and add a new testcase for the non-publish update case

…

On Thu, Jan 18, 2018 at 11:57 AM ChristopherGAndrews < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In aws/resource_aws_lambda_function.go <#3032 (comment)> : > } } +func updateComputedAttributesOnPublish(d *schema.ResourceDiff, meta interface{}) error { + publish := d.Get("publish").(bool) + if publish && needsFunctionCodeUpdate(d) { What if you did the following. It would make sure the last_modified was updated even if publish is set to false. if needsFunctionCodeUpdate(d) { d.SetNewComputed("last_modified") if publish { d.SetNewComputed("version") d.SetNewComputed("qualified_arn") } } — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3032 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGhlypfueMVYeEjTCxAKmOB_KNyCuJ5ks5tL3fggaJpZM4Rh05t> .

… update

mdlavin · 2018-01-24T22:29:35Z

@radeksimko is there anything else I should do to help this PR along?

TylerBrock · 2018-01-26T22:24:30Z

If we could get this one out it would be great, killing me right now to update this by hand. Thanks @mdlavin and @radeksimko!

TylerBrock · 2018-02-03T06:45:48Z

Any updates? I'd love to help if this still needs something to get it over the line.

mdlavin · 2018-02-13T22:18:51Z

Is there anything I can do to help get this merged?

bflad · 2018-02-13T22:35:22Z

Hi folks, sorry for the maintainer delay here. I'm not sure when I'll personally have time to get to this yet as I have quite a bunch already queued up (and I can't speak for the other maintainers), but let me at least tag it with an upcoming release so its on the radar. At a very quick glance this PR is probably okay but we'll want to double check more closely into its implications. Is anyone running this code in a custom build to report 👍 or 👎 experiences in their environment? Let's reaction vote on this comment please -- thanks!

mdlavin · 2018-02-13T22:38:31Z

I've been running this in a custom build since I posted my branch and I haven't seen any trouble with it

…

On Tue, Feb 13, 2018, 5:35 PM Brian Flad ***@***.***> wrote: Hi folks, sorry for the maintainer delay here. I'm not sure when I'll personally have time to get to this yet as I have quite a bunch already queued up (and I can't speak for the other maintainers), but let me at least tag it with an upcoming release so its on the radar. At a very quick glance this PR is probably okay but we'll want to double check more closely into its implications. Is anyone running this code in a custom build to report 👍 or 👎 experiences in their environment? Let's reaction vote on this comment please -- thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3032 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGhl56NuTGrVJDFMnayn0zJ-hTual-Mks5tUg4tgaJpZM4Rh05t> .

TylerBrock · 2018-02-16T04:19:18Z

Crossing my fingers for v1.10.0

TylerBrock · 2018-02-23T00:50:05Z

Please can we merge this one for v1.10.0, manually editing my tf files to update the version for every change is not fun at all.

TylerBrock · 2018-02-23T23:31:05Z

@bflad Is there anything the community can do beyond the above testing of @mdlavin's patch that can help?

bflad

LGTM! Thanks so much for this contribution! 🚀

(2 test failures unrelated)

=== RUN   TestAccAWSLambdaFunction_importS3
--- PASS: TestAccAWSLambdaFunction_importS3 (29.76s)
=== RUN   TestAccAWSLambdaFunction_s3
--- PASS: TestAccAWSLambdaFunction_s3 (31.42s)
=== RUN   TestAccAWSLambdaFunction_localUpdate_nameOnly
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (49.55s)
=== RUN   TestAccAWSLambdaFunction_localUpdate
--- PASS: TestAccAWSLambdaFunction_localUpdate (76.78s)
=== RUN   TestAccAWSLambdaFunction_expectFilenameAndS3Attributes
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (121.32s)
=== RUN   TestAccAWSLambdaFunction_runtimeValidation_noRuntime
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_noRuntime (0.77s)
=== RUN   TestAccAWSLambdaFunction_s3Update_basic
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (48.82s)
=== RUN   TestAccAWSLambdaFunction_VPC
--- FAIL: TestAccAWSLambdaFunction_VPC (130.85s)
=== RUN   TestAccAWSLambdaFunction_DeadLetterConfig
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (132.72s)
=== RUN   TestAccAWSLambdaFunction_versionedUpdate
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (184.01s)
=== RUN   TestAccAWSLambdaFunction_DeadLetterConfigUpdated
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (202.30s)
=== RUN   TestAccAWSLambdaFunction_encryptedEnvVariables
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (202.98s)
=== RUN   TestAccAWSLambdaFunction_s3Update_unversioned
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (105.74s)
=== RUN   TestAccAWSLambdaFunction_VPCUpdate
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (220.60s)
=== RUN   TestAccAWSLambdaFunction_importLocalFile
--- PASS: TestAccAWSLambdaFunction_importLocalFile (220.77s)
=== RUN   TestAccAWSLambdaFunction_runtimeValidation_python27
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python27 (92.32s)
=== RUN   TestAccAWSLambdaFunction_VPC_withInvocation
--- FAIL: TestAccAWSLambdaFunction_VPC_withInvocation (236.08s)
=== RUN   TestAccAWSLambdaFunction_runtimeValidation_java8
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_java8 (126.89s)
=== RUN   TestAccAWSLambdaFunction_basic
--- PASS: TestAccAWSLambdaFunction_basic (258.03s)
=== RUN   TestAccAWSLambdaFunction_versioned
--- PASS: TestAccAWSLambdaFunction_versioned (273.10s)
=== RUN   TestAccAWSLambdaFunction_runtimeValidation_nodeJs43
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_nodeJs43 (159.42s)
=== RUN   TestAccAWSLambdaFunction_updateRuntime
--- PASS: TestAccAWSLambdaFunction_updateRuntime (292.63s)
=== RUN   TestAccAWSLambdaFunction_concurrencyCycle
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (322.39s)
=== RUN   TestAccAWSLambdaFunction_tags
--- PASS: TestAccAWSLambdaFunction_tags (214.75s)
=== RUN   TestAccAWSLambdaFunction_envVariables
--- PASS: TestAccAWSLambdaFunction_envVariables (349.38s)
=== RUN   TestAccAWSLambdaFunction_runtimeValidation_python36
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python36 (174.45s)
=== RUN   TestAccAWSLambdaFunction_concurrency
--- PASS: TestAccAWSLambdaFunction_concurrency (375.63s)
=== RUN   TestAccAWSLambdaFunction_importLocalFile_VPC
--- PASS: TestAccAWSLambdaFunction_importLocalFile_VPC (442.52s)
=== RUN   TestAccAWSLambdaFunction_tracingConfig
--- PASS: TestAccAWSLambdaFunction_tracingConfig (482.08s)
=== RUN   TestAccAWSLambdaFunction_nilDeadLetterConfig
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (562.45s)

bflad · 2018-02-27T12:55:12Z

This has been released in version 1.10.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

rneu31 · 2018-07-24T22:27:40Z

@mdlavin @bflad Is this compatible with lifecycle ignore changes to filename? At first glance doesn't seem so.

I currently do applies on docker containers that add a different hash to ${path.module} which causes the filename to be "different" on each run.

ghost · 2020-04-04T17:33:46Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

mdlavin force-pushed the recompute-function-version-on-publish branch from 1f2539e to 6ef7474 Compare January 17, 2018 19:04

apparentlymart added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 18, 2018

ChristopherGAndrews reviewed Jan 18, 2018

View reviewed changes

radeksimko added bug Addresses a defect in current functionality. service/lambda Issues and PRs that pertain to the lambda service. and removed enhancement Requests to existing resources that expand the functionality or scope. labels Jan 18, 2018

mdlavin mentioned this pull request Jan 18, 2018

resource/aws_lambda_function: Add CustomizeDiff to force recompute of attributes on code change #3043

Closed

mdlavin changed the title ~~Recompute Lambda function version on publish~~ resource/aws_lambda_function: Recompute Lambda function version and qualified_arn on publish Jan 18, 2018

resource/aws_lambda_function: Recompute Lambda function version on pu…

485acc1

…blish

mdlavin force-pushed the recompute-function-version-on-publish branch from 6ef7474 to 3d666cf Compare January 18, 2018 13:34

resource/aws_lambda_function: Recompute qualified_arn and last_modifi…

db5bc3a

…ed on publish

mdlavin force-pushed the recompute-function-version-on-publish branch from 3d666cf to db5bc3a Compare January 18, 2018 13:55

ChristopherGAndrews reviewed Jan 18, 2018

View reviewed changes

resource/aws_lambda_function: Update last_modified on any source code…

963dddf

… update

bflad modified the milestones: v1.11.0, v1.10.0 Feb 13, 2018

mdlavin mentioned this pull request Feb 19, 2018

Handling of aws_lambda_alias on aws_lambda_function publish true #3192

Closed

bflad approved these changes Feb 24, 2018

View reviewed changes

bflad merged commit 093716e into hashicorp:master Feb 24, 2018

bflad added a commit that referenced this pull request Feb 24, 2018

Update CHANGELOG for #3032

1c83486

erran mentioned this pull request Mar 2, 2018

r/aws_lambda_function: terraform plan crashes on HasChange("filename") in CustomizeDiff introduced in #3032 #3605

Closed

ghost locked and limited conversation to collaborators Apr 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resource/aws_lambda_function: Recompute Lambda function version and qualified_arn on publish #3032

resource/aws_lambda_function: Recompute Lambda function version and qualified_arn on publish #3032

mdlavin commented Jan 17, 2018 •

edited

Loading

mdlavin commented Jan 18, 2018

ChristopherGAndrews Jan 18, 2018

mdlavin Jan 18, 2018

tmthrgd commented Jan 18, 2018

mdlavin commented Jan 18, 2018

ChristopherGAndrews Jan 18, 2018

mdlavin Jan 19, 2018

mdlavin commented Jan 18, 2018 via email

mdlavin commented Jan 24, 2018

TylerBrock commented Jan 26, 2018

TylerBrock commented Feb 3, 2018

mdlavin commented Feb 13, 2018

bflad commented Feb 13, 2018

mdlavin commented Feb 13, 2018 via email

TylerBrock commented Feb 16, 2018

TylerBrock commented Feb 23, 2018

TylerBrock commented Feb 23, 2018

bflad left a comment

bflad commented Feb 27, 2018

rneu31 commented Jul 24, 2018

ghost commented Apr 4, 2020

resource/aws_lambda_function: Recompute Lambda function version and qualified_arn on publish #3032

resource/aws_lambda_function: Recompute Lambda function version and qualified_arn on publish #3032

Conversation

mdlavin commented Jan 17, 2018 • edited Loading

mdlavin commented Jan 18, 2018

ChristopherGAndrews Jan 18, 2018

Choose a reason for hiding this comment

mdlavin Jan 18, 2018

Choose a reason for hiding this comment

tmthrgd commented Jan 18, 2018

mdlavin commented Jan 18, 2018

ChristopherGAndrews Jan 18, 2018

Choose a reason for hiding this comment

mdlavin Jan 19, 2018

Choose a reason for hiding this comment

mdlavin commented Jan 18, 2018 via email

mdlavin commented Jan 24, 2018

TylerBrock commented Jan 26, 2018

TylerBrock commented Feb 3, 2018

mdlavin commented Feb 13, 2018

bflad commented Feb 13, 2018

mdlavin commented Feb 13, 2018 via email

TylerBrock commented Feb 16, 2018

TylerBrock commented Feb 23, 2018

TylerBrock commented Feb 23, 2018

bflad left a comment

Choose a reason for hiding this comment

bflad commented Feb 27, 2018

rneu31 commented Jul 24, 2018

ghost commented Apr 4, 2020

mdlavin commented Jan 17, 2018 •

edited

Loading