Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_elastic_beanstalk_application: Prevent crash on reading missing application #3171

Merged
merged 1 commit into from
Jan 29, 2018
Merged

resource/aws_elastic_beanstalk_application: Prevent crash on reading missing application #3171

merged 1 commit into from
Jan 29, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 28, 2018 •
edited
Loading

Closes #3083

Testing passes:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSBeanstalkApp_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSBeanstalkApp_basic -timeout 120m
=== RUN   TestAccAWSBeanstalkApp_basic
--- PASS: TestAccAWSBeanstalkApp_basic (12.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	12.125s

make testacc TEST=./aws TESTARGS='-run=TestAWSElasticBeanstalkApplication'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAWSElasticBeanstalkApplication -timeout 120m
=== RUN   TestAWSElasticBeanstalkApplication_importBasic
--- PASS: TestAWSElasticBeanstalkApplication_importBasic (14.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.146s

@bflad bflad added crash Results from or addresses a Terraform crash or kernel panic. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. labels Jan 28, 2018
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Jan 28, 2018
radeksimko
radeksimko approved these changes Jan 29, 2018
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@bflad bflad added this to the v1.8.0 milestone Jan 29, 2018
@bflad bflad merged commit 1c4ea52 into master Jan 29, 2018
@bflad bflad deleted the b-aws_elastic_beanstalk_application-missing-app-crash branch January 29, 2018 08:30
bflad added a commit that referenced this pull request Jan 29, 2018
@bflad
Update CHANGELOG for #3171
cfa90cd
@bflad
Copy link
Contributor Author

bflad commented Jan 29, 2018

This has been released in terraform-provider-aws version 1.8.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

jocgir added a commit to coveooss/terraform-provider-aws that referenced this pull request Jan 31, 2018
@jocgir
Merge commit '8937a3a4e9d77c8089cf147861b604e3a2d8cf7e'
309f895 
* commit '8937a3a4e9d77c8089cf147861b604e3a2d8cf7e': (47 commits)
  v1.8.0
  Update CHANGELOG.md
  resource/aws_dynamodb_table: Refactoring (hashicorp#3136)
  Update CHANGELOG for hashicorp#3171
  resource/aws_elastic_beanstalk_application: Prevent crash on reading missing application
  chore(vendor): bump aws-sdk-go to v1.12.70
  typo guardduty import test
  Update CHANGELOG for hashicorp#3142
  Removed empty strings
  test/aws_dynamodb_global_table: Use single region for basic and import testing
  resource/aws_sqs_queue: Retry creation on QueueDeletedRecently for additional 10 seconds
  docs/CONTRIBUTING: Use aws_cloudwatch_dashboard for acceptance test examples
  docs/CONTRIBUTING: New Region: don't add empty mappings
  Update CHANGELOG.md
  resource/aws_rds_cluster: Retry deletion on InvalidDBClusterStateFault
  docs/CONTRIBUTING: Remove pre-split provider directory references from testacc commands
  Add service account IDs
  docs/CONTRIBUTING: New Region
  Support AWS cn-northwest-1 Ningxia (fixes hashicorp#3053)
  Update CHANGELOG.md
  ...

# Conflicts:
#	aws/validators.go
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
crash Results from or addresses a Terraform crash or kernel panic. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

unexpected EOF: panic: runtime error: invalid memory address or nil pointer dereference
2 participants
@bflad @radeksimko