Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Infer AWS partition from configured region #3173

Merged
merged 1 commit into from
Feb 5, 2018
Merged

provider: Infer AWS partition from configured region #3173

merged 1 commit into from
Feb 5, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 29, 2018 •
edited
Loading

Fixes part of #3045

Regions are part of an AWS partition and the AWS SDK endpoints package provides the functionality to determine the partition from the configured region name. We do not need the account ID fetching process (optionally skippable in the provider) to grab the partition.

make testacc TEST=./aws TESTARGS='-run=TestAccAWSS3Bucket_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSS3Bucket_basic -timeout 120m
=== RUN   TestAccAWSS3Bucket_basic
--- PASS: TestAccAWSS3Bucket_basic (26.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	26.254s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. proposal Proposes new design or functionality. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jan 29, 2018
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Jan 29, 2018
@bflad bflad mentioned this pull request Jan 29, 2018
Closed
catsby
catsby approved these changes Feb 5, 2018
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

[terraform-provider-aws][pr-3173]$ go test ./aws/... -run="TestAWSGetAccount"
ok      github.com/terraform-providers/terraform-provider-aws/aws       0.046s

@bflad bflad merged commit 8427cf8 into master Feb 5, 2018
@bflad bflad deleted the f-provider-infer-partition branch February 5, 2018 22:11
bflad added a commit that referenced this pull request Feb 5, 2018
@bflad
Update CHANGELOG for #3173
7c57e17
@bflad bflad added this to the v1.9.0 milestone Feb 9, 2018
@bflad
Copy link
Contributor Author

bflad commented Feb 9, 2018

This has been released in terraform-provider-aws version 1.9.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catsby catsby catsby approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. proposal Proposes new design or functionality. provider Pertains to the provider itself, rather than any interaction with AWS. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @catsby