-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/athena_named_query: Support import #3231
resource/athena_named_query: Support import #3231
Conversation
atsushi-ishibashi
commented
Feb 1, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work, again :)
Just left a nitpick before running tests and merge.
Importer: &schema.ResourceImporter{ | ||
State: schema.ImportStatePassthrough, | ||
}, | ||
|
||
Schema: map[string]*schema.Schema{ | ||
"name": &schema.Schema{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also remove these &schema.Schema
in this work?
Those are not needed since Go 1.7! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work, cleaning and reactivity, much appreciated! :)
Looks good to me! 🏎 🚀 😄
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAthenaNamedQuery_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSAthenaNamedQuery_ -timeout 120m
=== RUN TestAccAWSAthenaNamedQuery_basic
--- PASS: TestAccAWSAthenaNamedQuery_basic (89.31s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 89.357s
$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsAthenaNamedQuery_import'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAwsAthenaNamedQuery_import -timeout 120m
=== RUN TestAccAwsAthenaNamedQuery_import
--- PASS: TestAccAwsAthenaNamedQuery_import (86.05s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 86.100s
This has been released in terraform-provider-aws version 1.9.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |