New Resource: aws_dx_private_virtual_interface #3253

ewbankkit · 2018-02-04T23:17:37Z

aws/dx_vif.go and changes to aws/utils*.go shared with::

aws/tagsDX*.go copied from:

Add support for tagging aws_dx_lag and aws_dx_connection resources #2990

ewbankkit · 2018-02-04T23:28:07Z

Acceptance tests require an active Direct Connect connection which should be specified via the DX_CONNECTION_ID environment variable.

export DX_CONNECTION_ID=dxcon-xxxxxxxx
make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxPrivateVirtualInterface_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAwsDxPrivateVirtualInterface_ -timeout 120m
=== RUN   TestAccAwsDxPrivateVirtualInterface_basic
--- PASS: TestAccAwsDxPrivateVirtualInterface_basic (718.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	727.980s

ewbankkit · 2018-02-04T23:32:08Z

This PR and #3254 replace #876.

ewbankkit · 2018-02-04T23:33:24Z

Relates also to #2861.

grealish · 2018-06-19T16:29:04Z

does this PR require any testing, I'm currently working on some AWS direct connect deployments where I could test this if it helps to validate the PR before merging it?

ewbankkit · 2018-06-19T19:23:50Z

@grealish I have tested this on Direct Connections I have but additional testing is certainly welcome.
If you run the acceptance tests, set the environment variable DX_CONNECTION_ID before running the tests. See here.

ewbankkit · 2018-06-21T22:48:41Z

Rebased to remove conflicts.

…branch.

n3ph · 2018-06-22T15:55:39Z

Acceptance test is running successfully in eu-central-1

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxPrivateVirtualInterface_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAwsDxPrivateVirtualInterface_ -timeout 120m
=== RUN   TestAccAwsDxPrivateVirtualInterface_basic
--- PASS: TestAccAwsDxPrivateVirtualInterface_basic (494.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	494.877s

ewbankkit · 2018-06-22T16:48:33Z

Additional acceptance test with Direct Connect gateway after merge of #4896:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxPrivateVirtualInterface_dxGateway'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAwsDxPrivateVirtualInterface_dxGateway -timeout 120m
=== RUN   TestAccAwsDxPrivateVirtualInterface_dxGateway
--- PASS: TestAccAwsDxPrivateVirtualInterface_dxGateway (643.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	643.768s

n3ph · 2018-06-22T17:11:19Z

Confirming acceptance tests in eu-central-1

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxPrivateVirtualInterface_dxGateway'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAwsDxPrivateVirtualInterface_dxGateway -timeout 120m
=== RUN   TestAccAwsDxPrivateVirtualInterface_dxGateway
--- PASS: TestAccAwsDxPrivateVirtualInterface_dxGateway (522.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	522.650s

bflad

Looking good @ewbankkit! Can you please take a look at the below feedback and let us know if you have any questions?

bflad · 2018-06-22T17:07:23Z

aws/dx_vif.go

+func dxVirtualInterfaceUpdate(d *schema.ResourceData, meta interface{}) error {
+	conn := meta.(*AWSClient).dxconn
+
+	arn := arn.ARN{


We should prefer to create the arn manually once during create or read, set it in the Terraform state via d.Set("arn", ...), then use d.Get("arn").(string) or pass by value as necessary.

Once that's done, this function basically becomes nothing and the setTagsDX() bits can be duplicated where necessary to remove the dxVirtualInterfaceUpdate function. 👍

Yes, I'll Set the ARN after creation, once we have the Id and Get it elsewhere.

bflad · 2018-06-22T17:08:38Z

aws/dx_vif.go

+		VirtualInterfaceId: aws.String(d.Id()),
+	})
+	if err != nil {
+		if isAWSErr(err, "DirectConnectClientException", "does not exist") {


Minor nitpick: looks like the SDK has an available constant for this: directconnect.ErrCodeClientException

bflad · 2018-06-22T17:10:43Z

aws/dx_vif.go

+}
+
+// Attributes common to public VIFs and creator side of hosted public VIFs.
+func dxPublicVirtualInterfaceAttributes(d *schema.ResourceData, meta interface{}, vif *directconnect.VirtualInterface) error {


We generally prefer this logic to be duplicated across resources as necessary for long-term maintainability. 👍

Yes, I was thinking of that after removing mergeSchemas...

bflad · 2018-06-22T17:11:55Z

aws/dx_vif.go

+	return nil
+}
+
+func dxVirtualInterfaceArnAttribute(d *schema.ResourceData, meta interface{}) error {


Potential nitpick: this indirection to save two lines of code seems extraneous when it can just be duplicated to the relevant resources

I'll consolidate and inline all the attribute setting code directly into the resource's Read method.

bflad · 2018-06-22T17:13:02Z

aws/resource_aws_dx_private_virtual_interface.go

+			AddressFamily:        aws.String(d.Get("address_family").(string)),
+		},
+	}
+	if vgwOk {


For easier module support should this, and the other d.GetOk() conditionals below, also check for != ""?

bflad · 2018-06-22T17:14:28Z

aws/resource_aws_dx_private_virtual_interface_test.go

+	key := "DX_CONNECTION_ID"
+	connectionId := os.Getenv(key)
+	if connectionId == "" {
+		t.Skipf("Environment variable %s is not set", key)


bflad · 2018-06-22T17:16:45Z

website/docs/r/dx_private_virtual_interface.html.markdown

+* `vlan` - (Required) The VLAN ID.
+* `bgp_asn` - (Required) The autonomous system (AS) number for Border Gateway Protocol (BGP) configuration.
+* `bgp_auth_key` - (Optional) The authentication key for BGP configuration.
+* `address_family` - (Required) The address family for the BGP peer. `ipv4 ` or `ipv6`.


Minor nitpick: Can you organize these with Required at the top, alphabetical, then Optional, alphabetical. Thanks!

ewbankkit · 2018-06-22T19:34:05Z

Made review changes.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxPrivateVirtualInterface_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAwsDxPrivateVirtualInterface_ -timeout 120m
=== RUN   TestAccAwsDxPrivateVirtualInterface_basic
--- PASS: TestAccAwsDxPrivateVirtualInterface_basic (598.84s)
=== RUN   TestAccAwsDxPrivateVirtualInterface_dxGateway
--- PASS: TestAccAwsDxPrivateVirtualInterface_dxGateway (676.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1289.955s

bflad · 2018-06-22T19:59:25Z

@n3ph could you please also run the two acceptance tests on your connection? 👍

bflad

This LGTM pending someone else running the acceptance tests on a separate account and providing the output 👍

n3ph · 2018-06-23T11:51:58Z

Acceptance tests in eu-central-1

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxPrivateVirtualInterface_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAwsDxPrivateVirtualInterface_ -timeout 120m
=== RUN   TestAccAwsDxPrivateVirtualInterface_basic
--- PASS: TestAccAwsDxPrivateVirtualInterface_basic (666.82s)
=== RUN   TestAccAwsDxPrivateVirtualInterface_dxGateway
--- PASS: TestAccAwsDxPrivateVirtualInterface_dxGateway (661.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1328.321s

n3ph · 2018-06-23T14:20:49Z

Here is a small test case - So far everything is working as expected..

provider "aws" {
  max_retries = 3
  region      = "eu-central-1"
  profile     = "connect"
}

variable "connection_id" {
  default = "dxcon-xxxxxxxxx"
}

resource "aws_vpn_gateway" "test" {
  amazon_side_asn = 65100
}

resource "aws_dx_gateway" "test" {
  name            = "test"
  amazon_side_asn = 65200
}

resource "aws_dx_private_virtual_interface" "test_dx" {
  connection_id  = "${var.connection_id}"
  name           = "vif-test"
  vlan           = 1
  address_family = "ipv4"
  bgp_asn        = 65001
  dx_gateway_id  = "${aws_dx_gateway.test.id}"
}

resource "aws_dx_private_virtual_interface" "test_vpn" {
  connection_id  = "${var.connection_id}"
  name           = "vif-test"
  vlan           = 2
  address_family = "ipv4"
  bgp_asn        = 65002
  vpn_gateway_id = "${aws_vpn_gateway.test.id}"
}

$ terraform apply
data.aws_vpc.default: Refreshing state...

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  + aws_dx_gateway.test
      id:               <computed>
      amazon_side_asn:  "65200"
      name:             "test"

  + aws_dx_private_virtual_interface.test_dx
      id:               <computed>
      address_family:   "ipv4"
      amazon_address:   <computed>
      arn:              <computed>
      bgp_asn:          "65001"
      bgp_auth_key:     <computed>
      connection_id:    "dxcon-xxxxxxxx"
      customer_address: <computed>
      dx_gateway_id:    "${aws_dx_gateway.test.id}"
      name:             "vif-test_dx"
      vlan:             "1"

  + aws_dx_private_virtual_interface.test_vpn
      id:               <computed>
      address_family:   "ipv4"
      amazon_address:   <computed>
      arn:              <computed>
      bgp_asn:          "65002"
      bgp_auth_key:     <computed>
      connection_id:    "dxcon-xxxxxxxx"
      customer_address: <computed>
      name:             "vif-test_vpn"
      vlan:             "2"
      vpn_gateway_id:   "${aws_vpn_gateway.test.id}"

  + aws_vpn_gateway.test
      id:               <computed>
      amazon_side_asn:  "65100"
      vpc_id:           <computed>


Plan: 4 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

aws_dx_gateway.test: Creating...
  amazon_side_asn: "" => "65200"
  name:            "" => "test"
aws_vpn_gateway.test: Creating...
  amazon_side_asn: "" => "65100"
  vpc_id:          "" => "<computed>"
aws_vpn_gateway.test: Creation complete after 0s (ID: vgw-abf96c9b)
aws_dx_private_virtual_interface.test_vpn: Creating...
  address_family:   "" => "ipv4"
  amazon_address:   "" => "<computed>"
  arn:              "" => "<computed>"
  bgp_asn:          "" => "65002"
  bgp_auth_key:     "" => "<computed>"
  connection_id:    "" => "dxcon-xxxxxxxx"
  customer_address: "" => "<computed>"
  name:             "" => "vif-test_vpn"
  vlan:             "" => "2"
  vpn_gateway_id:   "" => "vgw-abf96c9b"
aws_dx_gateway.test: Still creating... (10s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still creating... (10s elapsed)
aws_dx_gateway.test: Creation complete after 10s (ID: c84df25b-e13f-4c07-9e67-e00b3b6e4e71)
aws_dx_private_virtual_interface.test_dx: Creating...
  address_family:   "" => "ipv4"
  amazon_address:   "" => "<computed>"
  arn:              "" => "<computed>"
  bgp_asn:          "" => "65001"
  bgp_auth_key:     "" => "<computed>"
  connection_id:    "" => "dxcon-xxxxxxxx"
  customer_address: "" => "<computed>"
  dx_gateway_id:    "" => "c84df25b-e13f-4c07-9e67-e00b3b6e4e71"
  name:             "" => "vif-test_dx"
  vlan:             "" => "1"
aws_dx_private_virtual_interface.test_vpn: Still creating... (20s elapsed)
aws_dx_private_virtual_interface.test_dx: Still creating... (10s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still creating... (30s elapsed)
aws_dx_private_virtual_interface.test_dx: Still creating... (20s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still creating... (40s elapsed)
aws_dx_private_virtual_interface.test_dx: Still creating... (30s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still creating... (50s elapsed)
aws_dx_private_virtual_interface.test_dx: Still creating... (40s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still creating... (1m0s elapsed)
aws_dx_private_virtual_interface.test_dx: Still creating... (50s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still creating... (1m10s elapsed)
aws_dx_private_virtual_interface.test_dx: Still creating... (1m0s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still creating... (1m20s elapsed)
aws_dx_private_virtual_interface.test_dx: Still creating... (1m10s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still creating... (1m30s elapsed)
aws_dx_private_virtual_interface.test_dx: Still creating... (1m20s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still creating... (1m40s elapsed)
aws_dx_private_virtual_interface.test_dx: Still creating... (1m30s elapsed)
aws_dx_private_virtual_interface.test_dx: Creation complete after 1m39s (ID: dxvif-ffnc6ih3)
aws_dx_private_virtual_interface.test_vpn: Creation complete after 1m50s (ID: dxvif-fg15d1du)

Apply complete! Resources: 4 added, 0 changed, 0 destroyed.

$ terraform apply
aws_vpn_gateway.test: Refreshing state... (ID: vgw-abf96c9b)
aws_dx_gateway.test: Refreshing state... (ID: c84df25b-e13f-4c07-9e67-e00b3b6e4e71)
data.aws_vpc.default: Refreshing state...
aws_dx_private_virtual_interface.test_dx: Refreshing state... (ID: dxvif-ffnc6ih3)
aws_dx_private_virtual_interface.test_vpn: Refreshing state... (ID: dxvif-fg15d1du)

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

$ terraform destroy
aws_vpn_gateway.test: Refreshing state... (ID: vgw-abf96c9b)
aws_dx_gateway.test: Refreshing state... (ID: c84df25b-e13f-4c07-9e67-e00b3b6e4e71)
data.aws_vpc.default: Refreshing state...
aws_dx_private_virtual_interface.test_dx: Refreshing state... (ID: dxvif-ffnc6ih3)
aws_dx_private_virtual_interface.test_vpn: Refreshing state... (ID: dxvif-fg15d1du)

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  - destroy

Terraform will perform the following actions:

  - aws_dx_gateway.test

  - aws_dx_private_virtual_interface.test_dx

  - aws_dx_private_virtual_interface.test_vpn

  - aws_vpn_gateway.test


Plan: 0 to add, 0 to change, 4 to destroy.

Do you really want to destroy?
  Terraform will destroy all your managed infrastructure, as shown above.
  There is no undo. Only 'yes' will be accepted to confirm.

  Enter a value: yes

aws_dx_private_virtual_interface.test_dx: Destroying... (ID: dxvif-ffnc6ih3)
aws_dx_private_virtual_interface.test_vpn: Destroying... (ID: dxvif-fg15d1du)
aws_dx_private_virtual_interface.test_dx: Still destroying... (ID: dxvif-ffnc6ih3, 10s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still destroying... (ID: dxvif-fg15d1du, 10s elapsed)
aws_dx_private_virtual_interface.test_dx: Still destroying... (ID: dxvif-ffnc6ih3, 20s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still destroying... (ID: dxvif-fg15d1du, 20s elapsed)
aws_dx_private_virtual_interface.test_dx: Still destroying... (ID: dxvif-ffnc6ih3, 30s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still destroying... (ID: dxvif-fg15d1du, 30s elapsed)
aws_dx_private_virtual_interface.test_dx: Still destroying... (ID: dxvif-ffnc6ih3, 40s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still destroying... (ID: dxvif-fg15d1du, 40s elapsed)
aws_dx_private_virtual_interface.test_dx: Still destroying... (ID: dxvif-ffnc6ih3, 50s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still destroying... (ID: dxvif-fg15d1du, 50s elapsed)
aws_dx_private_virtual_interface.test_dx: Still destroying... (ID: dxvif-ffnc6ih3, 1m0s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still destroying... (ID: dxvif-fg15d1du, 1m0s elapsed)
aws_dx_private_virtual_interface.test_dx: Still destroying... (ID: dxvif-ffnc6ih3, 1m10s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still destroying... (ID: dxvif-fg15d1du, 1m10s elapsed)
aws_dx_private_virtual_interface.test_dx: Still destroying... (ID: dxvif-ffnc6ih3, 1m20s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still destroying... (ID: dxvif-fg15d1du, 1m20s elapsed)
aws_dx_private_virtual_interface.test_dx: Still destroying... (ID: dxvif-ffnc6ih3, 1m30s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still destroying... (ID: dxvif-fg15d1du, 1m30s elapsed)
aws_dx_private_virtual_interface.test_dx: Still destroying... (ID: dxvif-ffnc6ih3, 1m40s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still destroying... (ID: dxvif-fg15d1du, 1m40s elapsed)
aws_dx_private_virtual_interface.test_dx: Still destroying... (ID: dxvif-ffnc6ih3, 1m50s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still destroying... (ID: dxvif-fg15d1du, 1m50s elapsed)
aws_dx_private_virtual_interface.test_dx: Still destroying... (ID: dxvif-ffnc6ih3, 2m0s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still destroying... (ID: dxvif-fg15d1du, 2m0s elapsed)
aws_dx_private_virtual_interface.test_dx: Still destroying... (ID: dxvif-ffnc6ih3, 2m10s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still destroying... (ID: dxvif-fg15d1du, 2m10s elapsed)
aws_dx_private_virtual_interface.test_dx: Still destroying... (ID: dxvif-ffnc6ih3, 2m20s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still destroying... (ID: dxvif-fg15d1du, 2m20s elapsed)
aws_dx_private_virtual_interface.test_dx: Still destroying... (ID: dxvif-ffnc6ih3, 2m30s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still destroying... (ID: dxvif-fg15d1du, 2m30s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still destroying... (ID: dxvif-fg15d1du, 2m40s elapsed)
aws_dx_private_virtual_interface.test_dx: Still destroying... (ID: dxvif-ffnc6ih3, 2m40s elapsed)
aws_dx_private_virtual_interface.test_vpn: Still destroying... (ID: dxvif-fg15d1du, 2m50s elapsed)
aws_dx_private_virtual_interface.test_dx: Still destroying... (ID: dxvif-ffnc6ih3, 2m50s elapsed)
aws_dx_private_virtual_interface.test_dx: Destruction complete after 3m0s
aws_dx_gateway.test: Destroying... (ID: c84df25b-e13f-4c07-9e67-e00b3b6e4e71)
aws_dx_private_virtual_interface.test_vpn: Still destroying... (ID: dxvif-fg15d1du, 3m0s elapsed)
aws_dx_private_virtual_interface.test_vpn: Destruction complete after 3m10s
aws_vpn_gateway.test: Destroying... (ID: vgw-abf96c9b)
aws_dx_gateway.test: Still destroying... (ID: c84df25b-e13f-4c07-9e67-e00b3b6e4e71, 10s elapsed)
aws_vpn_gateway.test: Destruction complete after 0s
aws_dx_gateway.test: Destruction complete after 10s

Destroy complete! Resources: 4 destroyed.

bflad · 2018-06-27T14:04:14Z

This has been released in version 1.25.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

ghost · 2020-04-05T17:12:53Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ghost added the size/XL Managed by automation to categorize the size of a PR. label Feb 4, 2018

bflad added new-resource Introduces a new resource. service/directconnect Issues and PRs that pertain to the directconnect service. labels Feb 5, 2018

ghost added the size/XL Managed by automation to categorize the size of a PR. label Feb 13, 2018

radeksimko changed the title ~~Add 'aws_dx_private_virtual_interface' resource~~ New Resource: aws_dx_private_virtual_interface Mar 23, 2018

ewbankkit mentioned this pull request Mar 29, 2018

[WIP] New Resources: aws_dx_private_vif, aws_dx_private_vif_allocation and aws_dx_private_vif_confirmation #3956

Closed

ewbankkit mentioned this pull request May 19, 2018

New resources: aws_dx_gateway, aws_dx_gateway_assocation #2861

Closed

ewbankkit mentioned this pull request Jun 20, 2018

Add support for Direct Connect Gateway #4896

Merged

ewbankkit and others added 3 commits June 21, 2018 18:46

Add 'aws_dx_private_virtual_interface' resource.

90488e0

Fix indentation for configuration generation.

d7bd808

Change interface to 'dxVirtualInterfaceRead'.

6a1f5a4

ewbankkit force-pushed the issue-3249 branch from 90d37dc to 6a1f5a4 Compare June 21, 2018 22:48

ghost added the size/XL Managed by automation to categorize the size of a PR. label Jun 21, 2018

Copy changes to 'dx_vif.go' and 'structure.go' from the 'issue-3248' …

e3b13ce

…branch.

Add 'TestAccAwsDxPrivateVirtualInterface_dxGateway'.

4b7d622

Remove 'mergeSchemas'.

2b93824

ewbankkit force-pushed the issue-3249 branch from eacee2b to 2b93824 Compare June 22, 2018 16:59

ghost added the size/XL Managed by automation to categorize the size of a PR. label Jun 22, 2018

bflad reviewed Jun 22, 2018

View reviewed changes

Changes after review.

173e1d9

ewbankkit pushed a commit to ewbankkit/terraform-provider-aws that referenced this pull request Jun 22, 2018

Changes after code review on hashicorp#3253.

4af87fd

bflad approved these changes Jun 22, 2018

View reviewed changes

ewbankkit pushed a commit to ewbankkit/terraform-provider-aws that referenced this pull request Jun 22, 2018

Changes after code review on hashicorp#3253.

a119b6d

ewbankkit pushed a commit to ewbankkit/terraform-provider-aws that referenced this pull request Jun 22, 2018

Changes after code review on hashicorp#3253.

adb1caa

bflad added this to the v1.25.0 milestone Jun 25, 2018

bflad merged commit 53e19f2 into hashicorp:master Jun 25, 2018

bflad added a commit that referenced this pull request Jun 25, 2018

Update CHANGELOG for #3253

0676933

ewbankkit deleted the issue-3249 branch June 25, 2018 14:01

bflad mentioned this pull request Jun 25, 2018

Add initial Direct Connect resources #876

Closed

ghost locked and limited conversation to collaborators Apr 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: aws_dx_private_virtual_interface #3253

New Resource: aws_dx_private_virtual_interface #3253

ewbankkit commented Feb 4, 2018 •

edited

Loading

ewbankkit commented Feb 4, 2018

ewbankkit commented Feb 4, 2018

ewbankkit commented Feb 4, 2018

grealish commented Jun 19, 2018

ewbankkit commented Jun 19, 2018

ewbankkit commented Jun 21, 2018

n3ph commented Jun 22, 2018 •

edited

Loading

ewbankkit commented Jun 22, 2018

n3ph commented Jun 22, 2018 •

edited

Loading

bflad left a comment

bflad Jun 22, 2018

ewbankkit Jun 22, 2018

bflad Jun 22, 2018

ewbankkit Jun 22, 2018

bflad Jun 22, 2018

ewbankkit Jun 22, 2018

bflad Jun 22, 2018

ewbankkit Jun 22, 2018

bflad Jun 22, 2018

ewbankkit Jun 22, 2018

bflad Jun 22, 2018

bflad Jun 22, 2018

ewbankkit Jun 22, 2018

ewbankkit commented Jun 22, 2018

bflad commented Jun 22, 2018

bflad left a comment

n3ph commented Jun 23, 2018 •

edited

Loading

n3ph commented Jun 23, 2018 •

edited

Loading

bflad commented Jun 27, 2018

ghost commented Apr 5, 2020

New Resource: aws_dx_private_virtual_interface #3253

New Resource: aws_dx_private_virtual_interface #3253

Conversation

ewbankkit commented Feb 4, 2018 • edited Loading

ewbankkit commented Feb 4, 2018

ewbankkit commented Feb 4, 2018

ewbankkit commented Feb 4, 2018

grealish commented Jun 19, 2018

ewbankkit commented Jun 19, 2018

ewbankkit commented Jun 21, 2018

n3ph commented Jun 22, 2018 • edited Loading

ewbankkit commented Jun 22, 2018

n3ph commented Jun 22, 2018 • edited Loading

bflad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ewbankkit commented Jun 22, 2018

bflad commented Jun 22, 2018

bflad left a comment

Choose a reason for hiding this comment

n3ph commented Jun 23, 2018 • edited Loading

n3ph commented Jun 23, 2018 • edited Loading

bflad commented Jun 27, 2018

ghost commented Apr 5, 2020

ewbankkit commented Feb 4, 2018 •

edited

Loading

n3ph commented Jun 22, 2018 •

edited

Loading

n3ph commented Jun 22, 2018 •

edited

Loading

n3ph commented Jun 23, 2018 •

edited

Loading

n3ph commented Jun 23, 2018 •

edited

Loading