Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_s3_bucket: Prevent crashes on location and replication read retry timeouts #3338

Merged
merged 1 commit into from
Feb 13, 2018
Merged

resource/aws_s3_bucket: Prevent crashes on location and replication read retry timeouts #3338

merged 1 commit into from
Feb 13, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 12, 2018

Moves variable setting below err check. 😄

Fixes #3325

@bflad bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/s3 Issues and PRs that pertain to the s3 service. labels Feb 12, 2018
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Feb 12, 2018
@bflad bflad added this to the v1.10.0 milestone Feb 12, 2018
radeksimko
radeksimko approved these changes Feb 13, 2018
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@bflad bflad merged commit 33d309d into master Feb 13, 2018
@bflad bflad deleted the b-aws_s3_bucket-timeout-crash branch February 13, 2018 12:01
bflad added a commit that referenced this pull request Feb 13, 2018
@bflad
Update CHANGELOG for #3338
393aa85
@bflad
Copy link
Contributor Author

bflad commented Feb 27, 2018

This has been released in version 1.10.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.

* aws_s3_bucket.bucket: unexpected EOF
2 participants
@bflad @radeksimko