Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_lb_listener: Retry CertificateNotFound errors on update for IAM eventual consistency #3901

Merged
merged 2 commits into from
Mar 26, 2018
Merged

resource/aws_lb_listener: Retry CertificateNotFound errors on update for IAM eventual consistency #3901

merged 2 commits into from
Mar 26, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 23, 2018

Closes #2053

Tests

pending

@bflad bflad added bug Addresses a defect in current functionality. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Mar 23, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Mar 23, 2018
@bflad bflad mentioned this pull request Mar 23, 2018
Closed
radeksimko
radeksimko approved these changes Mar 26, 2018
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as relevant acceptance tests pass.

aws/resource_aws_lb_listener.go
if awsErr.Code() == "CertificateNotFound" {
log.Printf("[WARN] Got an error while trying to create LB listener for ARN: %s: %s", lbArn, err)
if err != nil {
if isAWSErr(err, elbv2.ErrCodeCertificateNotFoundException, "") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Do you mind making a similar change in isListenerNotFound at the bottom of this file, so we can get rid of the awserr package import? 🙂

@bflad bflad added this to the v1.13.0 milestone Mar 26, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Mar 26, 2018
@bflad
Copy link
Contributor Author

bflad commented Mar 26, 2018

Updated and looks fine (unrelated other eventual consistency issue):

Tests failed: 1 (1 new), passed: 8
=== RUN   TestAccAWSLBListenerRule_multipleConditionThrowsError
--- PASS: TestAccAWSLBListenerRule_multipleConditionThrowsError (1.37s)
=== RUN   TestAccAWSLBListenerRule_basic
--- PASS: TestAccAWSLBListenerRule_basic (192.93s)
=== RUN   TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (207.45s)
=== RUN   TestAccAWSLBListenerRuleBackwardsCompatibility
--- PASS: TestAccAWSLBListenerRuleBackwardsCompatibility (215.42s)
=== RUN   TestAccAWSLBListenerBackwardsCompatibility
--- PASS: TestAccAWSLBListenerBackwardsCompatibility (222.14s)
=== RUN   TestAccAWSLBListener_basic
--- PASS: TestAccAWSLBListener_basic (239.22s)
=== RUN   TestAccAWSLBListener_https
--- PASS: TestAccAWSLBListener_https (276.29s)
=== RUN   TestAccAWSLBListenerRule_updateRulePriority
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (291.13s)
=== RUN   TestAccAWSLBListenerRule_priority
--- FAIL: TestAccAWSLBListenerRule_priority (345.32s)
    testing.go:518: Step 5 error: Check failed: Check 1/2 error: Not found: aws_lb_listener_rule.50000

@bflad bflad merged commit dd604ed into master Mar 26, 2018
@bflad bflad deleted the b-aws_lb_listener-update-certificatenotfound branch March 26, 2018 18:00
bflad added a commit that referenced this pull request Mar 26, 2018
@bflad
Update CHANGELOG for #3901
26083f4
@bflad
Copy link
Contributor Author

bflad commented Mar 29, 2018

This has been released in version 1.13.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

aws_lb_listener can't find just created aws_iam_server_certificate - error:CertificateNotFound
2 participants
@bflad @radeksimko