Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_wafregional_regex_pattern_set #3933

Merged
merged 1 commit into from
Mar 27, 2018
Merged

New Resource: aws_wafregional_regex_pattern_set #3933

merged 1 commit into from
Mar 27, 2018

Conversation

radeksimko
Copy link
Member

Test results

TF_ACC=1 go test ./aws -v -run=TestAccAWSWafRegionalRegexPatternSet_ -timeout 120m
=== RUN   TestAccAWSWafRegionalRegexPatternSet_basic
--- PASS: TestAccAWSWafRegionalRegexPatternSet_basic (45.56s)
=== RUN   TestAccAWSWafRegionalRegexPatternSet_changePatterns
--- PASS: TestAccAWSWafRegionalRegexPatternSet_changePatterns (79.35s)
=== RUN   TestAccAWSWafRegionalRegexPatternSet_noPatterns
--- PASS: TestAccAWSWafRegionalRegexPatternSet_noPatterns (33.02s)
=== RUN   TestAccAWSWafRegionalRegexPatternSet_disappears
--- PASS: TestAccAWSWafRegionalRegexPatternSet_disappears (33.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	191.232s

@radeksimko radeksimko added new-resource Introduces a new resource. service/waf Issues and PRs that pertain to the waf service. labels Mar 27, 2018
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Mar 27, 2018
@hashibot hashibot mentioned this pull request Mar 27, 2018
Closed
13 tasks
appilon
appilon approved these changes Mar 27, 2018
View reviewed changes
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radeksimko radeksimko merged commit 197242f into master Mar 27, 2018
@radeksimko radeksimko deleted the f-wafregional-regex-pattern-set branch March 27, 2018 16:45
@bflad bflad added this to the v1.13.0 milestone Mar 29, 2018
@bflad
Copy link
Contributor

bflad commented Mar 29, 2018

This has been released in version 1.13.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appilon appilon appilon approved these changes

Assignees
No one assigned
Labels
new-resource Introduces a new resource. service/waf Issues and PRs that pertain to the waf service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@radeksimko @bflad @appilon