Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-source/aws_iam_role: Add max_session_duration attribute #4092

Merged
merged 1 commit into from
Apr 6, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 6, 2018

New max_session_duration attribute was added in master to the aws_iam_role resource but not the data source:

=== RUN   TestAccAWSDataSourceIAMRole_basic
--- FAIL: TestAccAWSDataSourceIAMRole_basic (6.81s)
    testing.go:518: Step 0 error: Error applying: 1 error(s) occurred:
        
        * data.aws_iam_role.test: data.aws_iam_role.test: Invalid address to set: []string{"max_session_duration"}
    testing.go:579: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
        
        Error: Error refreshing: 1 error(s) occurred:
        
        * data.aws_iam_role.test: 1 error(s) occurred:
        
        * data.aws_iam_role.test: data.aws_iam_role.test: Invalid address to set: []string{"max_session_duration"}
        
        State: <nil>
FAIL

Now:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSourceIAMRole_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSDataSourceIAMRole_basic -timeout 120m
=== RUN   TestAccAWSDataSourceIAMRole_basic
--- PASS: TestAccAWSDataSourceIAMRole_basic (11.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	11.877s

@bflad bflad added bug Addresses a defect in current functionality. service/iam Issues and PRs that pertain to the iam service. labels Apr 6, 2018
@bflad bflad added this to the v1.14.0 milestone Apr 6, 2018
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Apr 6, 2018
@bflad bflad requested a review from a team April 6, 2018 16:07
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad merged commit 8f95db8 into master Apr 6, 2018
@bflad bflad deleted the b-aws_iam_role-ds-maxsessionduration branch April 6, 2018 16:19
bflad added a commit that referenced this pull request Apr 6, 2018
@bflad
Copy link
Contributor Author

bflad commented Apr 6, 2018

This has been released in version 1.14.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/iam Issues and PRs that pertain to the iam service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants