ForceNew on Lambda alias name change #4106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test demonstrates the bug in #4090
The name functions as the "id" here, with regards to identifying the alias for an update operation
catsby
added
bug
|
Tests passing:
|
bflad
approved these changes
Apr 9, 2018
| testAccCheckAwsLambdaAliasExists("aws_lambda_alias.lambda_alias_test", &conf), | ||
| testAccCheckAwsLambdaAttributes(&conf), | ||
| resource.TestMatchResourceAttr("aws_lambda_alias.lambda_alias_test", "arn", | ||
| regexp.MustCompile(`^arn:aws:lambda:[a-z]+-[a-z]+-[0-9]+:\d{12}:function:`+funcName+`:`+aliasName+`$`)), |
There was a problem hiding this comment.
Future note: When we start testing outside the aws partition (e.g. US Government) these will break. We can go with something like ^arn:[^:]+:lambda:..., create a partition regex constant, or create our own test check wrapper function for AWS ARNs.
|
This has been released in version 1.14.1 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating a Lamda Alias, the API uses the
nameas the ID of the alias to update. When updating thenameofaws_lambda_alias, we're sending the newnamefrom the config, which isn't found, so Terraform errors.The next
planreads the newnamefrom the config, and shows an addition to be made (not an update). Applying then creates a new alias, and orphans the old one.91d8b16 is a regression test that will fail on the current
master(84353e4)Fixes #4090