Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_cognito_user_group: Fix role_arn updates #4237

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 17, 2018

Fixes #4236

Previously (before code change):

make testacc TEST=./aws TESTARGS='-run=TestAccAWSCognitoUserGroup_RoleArn'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCognitoUserGroup_RoleArn -timeout 120m
=== RUN   TestAccAWSCognitoUserGroup_RoleArn
--- FAIL: TestAccAWSCognitoUserGroup_RoleArn (18.61s)
	testing.go:518: Step 1 error: Error applying: 1 error(s) occurred:

		* aws_cognito_user_group.main: 1 error(s) occurred:

		* aws_cognito_user_group.main: Error updating Cognito User Group: InvalidParameter: 1 validation error(s) found.
		- minimum field size of 20, UpdateGroupInput.RoleArn.

FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	18.650s
make: *** [testacc] Error 1

Now:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSCognitoUserGroup_RoleArn'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCognitoUserGroup_RoleArn -timeout 120m
=== RUN   TestAccAWSCognitoUserGroup_RoleArn
--- PASS: TestAccAWSCognitoUserGroup_RoleArn (22.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	22.946s

@bflad bflad added bug Addresses a defect in current functionality. service/cognito labels Apr 17, 2018
@bflad bflad added this to the v1.15.0 milestone Apr 17, 2018
@bflad bflad requested a review from a team April 17, 2018 17:03
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Apr 17, 2018
@bflad bflad merged commit 53d19d8 into master Apr 17, 2018
@bflad bflad deleted the b-aws_cognito_user_group-role_arn-updates branch April 17, 2018 23:11
bflad added a commit that referenced this pull request Apr 17, 2018
@bflad
Copy link
Contributor Author

bflad commented Apr 18, 2018

This has been released in version 1.15.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_cognito_user_group passes group description in AWS request as role_arn property
2 participants