Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_glue_catalog_table: Prevent multiple panics #4621

Merged
merged 1 commit into from
May 23, 2018
Merged

resource/aws_glue_catalog_table: Prevent multiple panics #4621

merged 1 commit into from
May 23, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 23, 2018

Fixes #4618

Changes proposed in this pull request:

  • Prevent multiple potential dereference panics
  • Prevent multiple potential index out of range panics
  • Refactor out flattenStringParameters() (which could have panicked) to standard SDK aws.StringValueMap() method

Output from acceptance testing:

5 tests passed (all tests)
=== RUN   TestAccAWSGlueCatalogTable_basic
--- PASS: TestAccAWSGlueCatalogTable_basic (8.50s)
=== RUN   TestAccAWSGlueCatalogTable_full
--- PASS: TestAccAWSGlueCatalogTable_full (8.73s)
=== RUN   TestAccAWSGlueCatalogTable_importBasic
--- PASS: TestAccAWSGlueCatalogTable_importBasic (9.12s)
=== RUN   TestAccAWSGlueCatalogTable_update_addValues
--- PASS: TestAccAWSGlueCatalogTable_update_addValues (13.67s)
=== RUN   TestAccAWSGlueCatalogTable_update_replaceValues
--- PASS: TestAccAWSGlueCatalogTable_update_replaceValues (13.76s)

@bflad bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/glue Issues and PRs that pertain to the glue service. labels May 23, 2018
@bflad bflad requested a review from a team May 23, 2018 15:05
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label May 23, 2018
@bflad bflad mentioned this pull request May 23, 2018
Closed
tombuildsstuff
tombuildsstuff approved these changes May 23, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.20.0 milestone May 23, 2018
@bflad bflad merged commit c70a0d3 into master May 23, 2018
@bflad bflad deleted the b-aws_glue_catalog_table-index-panic branch May 23, 2018 15:26
bflad added a commit that referenced this pull request May 23, 2018
@bflad
Update CHANGELOG for #4621
69992be
@cemo
Copy link

cemo commented May 23, 2018

I tested new release. It is OK. 👍

@bflad
Copy link
Contributor Author

bflad commented May 23, 2018

This has been released in version 1.20.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.20.0
Development

Successfully merging this pull request may close these issues.

aws_glue_catalog_table crash
3 participants
@bflad @cemo @tombuildsstuff