Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codebuild secret preservation #4775

Merged
merged 4 commits into from
Jun 12, 2018

Conversation

gthole
Copy link
Contributor

@gthole gthole commented Jun 7, 2018

Fixes #4720

Changes proposed in this pull request:

  • Only set the secret attribute on resource creation, since it's never returned again from the AWS API after creation (despite what the API docs say.)
  • Make the secret attribute sensitive.
  • Add extra steps to GithubEnterprise test to confirm update mechanism successfully modifies the branchFilter without losing the the secret.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeBuildWebhook'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSCodeBuildWebhook -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSCodeBuildWebhook_GitHub
--- PASS: TestAccAWSCodeBuildWebhook_GitHub (21.37s)
=== RUN   TestAccAWSCodeBuildWebhook_GitHubEnterprise
--- PASS: TestAccAWSCodeBuildWebhook_GitHubEnterprise (35.58s)
=== RUN   TestAccAWSCodeBuildWebhook_BranchFilter
--- PASS: TestAccAWSCodeBuildWebhook_BranchFilter (32.86s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       89.836s

NB: To get the Github cases to pass, I modified the codebuild_project location to point to my fork of hashibot-test/aws-test.git. That change is not reflected in the committed code.

@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jun 7, 2018
@bflad bflad added bug Addresses a defect in current functionality. service/codebuild Issues and PRs that pertain to the codebuild service. labels Jun 12, 2018
@bflad bflad added this to the v1.23.0 milestone Jun 12, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for this fix @gthole! 🚀

@bflad bflad merged commit 05fd6f4 into hashicorp:master Jun 12, 2018
bflad added a commit that referenced this pull request Jun 12, 2018
@bflad
Copy link
Contributor

bflad commented Jun 14, 2018

This has been released in version 1.23.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/codebuild Issues and PRs that pertain to the codebuild service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_codebuild_webhook: Secret not propagated to GHE webhook as in documentation example
2 participants