Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_storagegateway_gateway #5208

Merged
merged 2 commits into from
Jul 18, 2018
Merged

New Resource: aws_storagegateway_gateway #5208

merged 2 commits into from
Jul 18, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 16, 2018

Reference: #943

Changes proposed in this pull request:

  • Removes unreleased and invalid aws_storagegateway_gateway_activation_key data source -- the activation key is not accessible after gateway activation
  • Add new resource aws_storagegateway_gateway

Output from acceptance testing:

=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Cached
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Cached (267.05s)
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_FileS3
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (248.33s)
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Stored
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Stored (301.00s)
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Vtl
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Vtl (229.60s)
=== RUN   TestAccAWSStorageGatewayGateway_GatewayName
--- PASS: TestAccAWSStorageGatewayGateway_GatewayName (271.00s)
=== RUN   TestAccAWSStorageGatewayGateway_GatewayTimezone
--- PASS: TestAccAWSStorageGatewayGateway_GatewayTimezone (287.73s)

@bflad
New Resource: aws_storagegateway_gateway
c61d3ac 
Removes unreleased and invalid aws_storagegateway_gateway_activation_key data source -- the activation key is not accessible after gateway activation
@bflad bflad added new-resource Introduces a new resource. service/storagegateway Issues and PRs that pertain to the storagegateway service. labels Jul 16, 2018
@bflad bflad requested a review from a team July 16, 2018 21:05
@ghost ghost added the size/XXL Managed by automation to categorize the size of a PR. label Jul 16, 2018
tombuildsstuff
tombuildsstuff approved these changes Jul 18, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍

website/docs/r/storagegateway_gateway.html.markdown Outdated
The following arguments are supported:

* `gateway_name` - (Required) Name of the gateway.
* `gateway_timezone` - (Required) Time zone for the gateway. The time zone is of the format "GMT-hr:mm" or "GMT+hr:mm". For example, `GMT-4:00` indicates the time is 4 hours behind GMT. The time zone is used, for example, for scheduling snapshots and your gateway's maintenance schedule.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be UTC in addition to GMT? should also mention this can just be GMT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using UTC I receive an error from the API 😄 aws_storagegateway_gateway.test: error activating Storage Gateway Gateway: InvalidGatewayRequestException: The specified request contains invalid parameters. -- I will add "GMT" as a valid option in documentation!

Not asked probably worth noting that given the API reference, I would be a little hesitant to implement strict plan time validation for ^GMT 😅

A value that indicates the time zone you want to set for the gateway. The time zone is of the format "GMT-hr:mm" or "GMT+hr:mm". For example, GMT-4:00 indicates the time is 4 hours behind GMT. GMT+2:00 indicates the time is 2 hours ahead of GMT. The time zone is used, for example, for scheduling snapshots and your gateway's maintenance schedule.

Type: String

Length Constraints: Minimum length of 3. Maximum length of 10.

@bflad bflad added this to the v1.28.0 milestone Jul 18, 2018
@bflad bflad merged commit 91218e0 into master Jul 18, 2018
@bflad bflad deleted the f-aws_storagegateway_gateway branch July 18, 2018 20:14
bflad added a commit that referenced this pull request Jul 18, 2018
@bflad
Update CHANGELOG for #5208
12ffe32
@bflad
Copy link
Contributor Author

bflad commented Jul 18, 2018

This has been released in version 1.28.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
new-resource Introduces a new resource. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @tombuildsstuff