Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: aws_storagegateway_local_disk #5279

Closed
wants to merge 1 commit into from
Closed

New Data Source: aws_storagegateway_local_disk #5279

wants to merge 1 commit into from

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 20, 2018

Prerequisite for cache and upload buffer resources.

Reference: #943

Changes proposed in this pull request:

  • New Data Source: aws_storagegateway_local_disk

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewayLocalDiskDataSource_DiskPath'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSStorageGatewayLocalDiskDataSource_DiskPath -timeout 120m
=== RUN   TestAccAWSStorageGatewayLocalDiskDataSource_DiskPath
--- PASS: TestAccAWSStorageGatewayLocalDiskDataSource_DiskPath (289.82s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	290.429s

@bflad bflad added new-data-source Introduces a new data source. service/storagegateway Issues and PRs that pertain to the storagegateway service. labels Jul 20, 2018
@bflad bflad requested a review from a team July 20, 2018 19:17
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Jul 20, 2018
This was referenced Jul 20, 2018
Merged
Merged
Merged
Closed
@bflad bflad added this to the v1.30.0 milestone Jul 27, 2018
@bflad
Copy link
Contributor Author

bflad commented Jul 27, 2018

Merged as part of #5285 with a separate commit SHA since that PR was rebased before merge. 👍

@bflad bflad closed this Jul 27, 2018
@bflad bflad deleted the f-aws_storagegateway_local_disk branch July 27, 2018 19:35
bflad added a commit that referenced this pull request Jul 27, 2018
@bflad
Update CHANGELOG for #5279 and #5285
e9d7a37
@bflad
Copy link
Contributor Author

bflad commented Aug 2, 2018

This has been released in version 1.30.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
new-data-source Introduces a new data source. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.
1 participant
@bflad