Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_storagegateway_upload_buffer #5284

Merged
merged 1 commit into from
Jul 27, 2018
Merged

New Resource: aws_storagegateway_upload_buffer #5284

merged 1 commit into from
Jul 27, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 20, 2018

Built on #5279
Reference: #943

Changes proposed in this pull request:

  • New Resource: aws_storagegateway_upload_buffer

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewayUploadBuffer_Basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSStorageGatewayUploadBuffer_Basic -timeout 120m
=== RUN   TestAccAWSStorageGatewayUploadBuffer_Basic
--- PASS: TestAccAWSStorageGatewayUploadBuffer_Basic (269.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	270.097s

@bflad bflad added new-resource Introduces a new resource. service/storagegateway Issues and PRs that pertain to the storagegateway service. labels Jul 20, 2018
@bflad bflad requested a review from a team July 20, 2018 21:40
@ghost ghost added the size/XL Managed by automation to categorize the size of a PR. label Jul 20, 2018
@bflad bflad mentioned this pull request Jul 20, 2018
Closed
appilon
appilon approved these changes Jul 27, 2018
View reviewed changes
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed between this and another PR local_disk is duplicated in that PR? probably things just need merging + rebasing

@bflad bflad added this to the v1.30.0 milestone Jul 27, 2018
@bflad bflad force-pushed the f-aws_storagegateway_upload_buffer branch from 144358a to 6aa56f9 Compare July 27, 2018 19:39
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 27, 2018
@bflad
Copy link
Contributor Author

bflad commented Jul 27, 2018

Rebased on top of master with no surprises from CI, merging!

@bflad bflad merged commit 31333c4 into master Jul 27, 2018
@bflad bflad deleted the f-aws_storagegateway_upload_buffer branch July 27, 2018 19:51
bflad added a commit that referenced this pull request Jul 27, 2018
@bflad
Update CHANGELOG for #5284 and fix ordering for #5285
34a7ab1
@bflad
Copy link
Contributor Author

bflad commented Aug 2, 2018

This has been released in version 1.30.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appilon appilon appilon approved these changes

Assignees
No one assigned
Labels
new-resource Introduces a new resource. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @appilon