Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arn for aws_subnet and data.aws_subnet #5486

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

blckct
Copy link
Contributor

@blckct blckct commented Aug 8, 2018

Changes proposed in this pull request:

  • Add ARN attribute to aws_subnet and data.aws_subnet
  • Update documentation

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccDataSourceAwsSubnet_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccDataSourceAwsSubnet_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccDataSourceAwsSubnet_basic
--- PASS: TestAccDataSourceAwsSubnet_basic (63.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	63.640s
make testacc TESTARGS='-run=TestAccAWSSubnet_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSSubnet_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSSubnet_basic
--- PASS: TestAccAWSSubnet_basic (58.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	58.711s

@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Aug 8, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Aug 8, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @blckct! 🚀

9 tests passed (all tests)
=== RUN   TestAccAWSSubnet_importBasic
--- PASS: TestAccAWSSubnet_importBasic (12.91s)
=== RUN   TestAccAWSSubnet_basic
--- PASS: TestAccAWSSubnet_basic (13.11s)
=== RUN   TestAccDataSourceAwsSubnetIDs_filter
--- PASS: TestAccDataSourceAwsSubnetIDs_filter (18.41s)
=== RUN   TestAccAWSSubnet_enableIpv6
--- PASS: TestAccAWSSubnet_enableIpv6 (20.02s)
=== RUN   TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter (22.22s)
=== RUN   TestAccDataSourceAwsSubnetIDs
--- PASS: TestAccDataSourceAwsSubnetIDs (23.32s)
=== RUN   TestAccDataSourceAwsSubnet_basic
--- PASS: TestAccDataSourceAwsSubnet_basic (26.60s)
=== RUN   TestAccAWSSubnet_ipv6
--- PASS: TestAccAWSSubnet_ipv6 (29.31s)
=== RUN   TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock (34.07s)

@bflad bflad added this to the v1.32.0 milestone Aug 9, 2018
@bflad bflad merged commit f56d3f5 into hashicorp:master Aug 9, 2018
bflad added a commit that referenced this pull request Aug 9, 2018
@bflad
Copy link
Contributor

bflad commented Aug 16, 2018

This has been released in version 1.32.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@blckct blckct deleted the subnet_add_arn branch May 26, 2019 22:55
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants